Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement account discovery of Solana Accounts when restoring wallet from seed #22969

Closed
srirambv opened this issue May 20, 2022 · 4 comments · Fixed by brave/brave-core#18283
Closed

Implement account discovery of Solana Accounts when restoring wallet from seed #22969

srirambv opened this issue May 20, 2022 · 4 comments · Fixed by brave/brave-core#18283
Assignees
@cypt4
Labels
feature/web3/wallet/core feature/web3/wallet/solana feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.56.x - Release

Comments

@srirambv
Copy link
Contributor

Similar to #18104, we should consider restoring Solana Accounts if there has been any transactions done.

cc: @jamesmudgett @darkdh
@srirambv srirambv added this to Web3 May 20, 2022
@darkdh
Copy link
Member

darkdh commented May 20, 2022

use https://docs.solana.com/developing/clients/jsonrpc-api#gettransactioncount

@jamesmudgett
Copy link

#23061 related

@jamesmudgett jamesmudgett added the priority/P4 Planned work. We expect to get to it "soon". label Jun 7, 2022
@jamesmudgett jamesmudgett moved this to Backlog in Web3 Jun 7, 2022
@yrliou
Copy link
Member

yrliou commented Feb 7, 2023 •
edited
Loading

Seems like Solana getTransactionCount is not what we want, we can probably use https://docs.solana.com/api/http#getsignaturesforaddress instead.

@yrliou yrliou added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P4 Planned work. We expect to get to it "soon". labels Feb 7, 2023
@cypt4 cypt4 mentioned this issue May 2, 2023
Merged
25 tasks
@github-project-automation github-project-automation bot moved this from Backlog to Done in Web3 May 5, 2023
@brave-builds brave-builds added this to the 1.53.x - Nightly milestone May 5, 2023
@srirambv
Copy link
Contributor Author

Verified as part of #28002 (comment)

@LaurenWags LaurenWags mentioned this issue Jul 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cypt4 cypt4

Labels
feature/web3/wallet/core feature/web3/wallet/solana feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.56.x - Release
Development

Successfully merging a pull request may close this issue.

Auto Discovery for Filecoin and Solana Accounts brave/brave-core
6 participants
@jamesmudgett @yrliou @darkdh @srirambv @brave-builds @cypt4