Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rotating hash to payload #23055

Closed
tmancey opened this issue May 25, 2022 · 1 comment · Fixed by brave/brave-core#13465
Closed

Add rotating hash to payload #23055

tmancey opened this issue May 25, 2022 · 1 comment · Fixed by brave/brave-core#13465
Assignees
@tmancey
Labels
enhancement feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. privacy QA Pass-Linux QA/Yes release-notes/exclude
Milestone
1.43.x - Release

Comments

@tmancey
Copy link
Contributor

tmancey commented May 25, 2022 •
edited
Loading

See https://github.com/brave/security/issues/880 for context
@tmancey tmancey self-assigned this May 25, 2022
@tmancey tmancey mentioned this issue May 25, 2022
Merged
24 tasks
@brave-builds brave-builds added this to the 1.43.x - Nightly milestone Jul 14, 2022
@btlechowski
Copy link

btlechowski commented Aug 10, 2022 •
edited
Loading

Verification passed on

Brave 1.43.63 Chromium: 104.0.5112.81 (Official Build) beta (64-bit)
Revision 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS Ubuntu 18.04 LTS

rotating hash is the same for different versions for the same ad

1.44.x
image

1.43.x
image

rotating hash is different for different creative instance ids

image
Different ad:
image

rotating hash is rotating every 1h

image

NTP SI

image

@tmancey tmancey mentioned this issue Aug 23, 2022
Closed
4 tasks
@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
enhancement feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. privacy QA Pass-Linux QA/Yes release-notes/exclude
Projects
Ads
Archived in project
Milestone
1.43.x - Release
Development

Successfully merging a pull request may close this issue.

Add time based rotating hash to payload brave/brave-core
3 participants
@tmancey @btlechowski @brave-builds