Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Buttons to Account List Item #23743

Closed
Douglashdaniel opened this issue Jun 28, 2022 · 1 comment · Fixed by brave/brave-core#15048
Closed

Add Buttons to Account List Item #23743

Douglashdaniel opened this issue Jun 28, 2022 · 1 comment · Fixed by brave/brave-core#15048
Assignees
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@Douglashdaniel
Copy link

Description

Add Buttons to Account List Item

  • Buttons should only appear on Hover
  • Export button should pop open the Export Private Key modal
  • Deposit button should pop open the QR modal
  • Edit button should pop open the Rename Account modal or Rename Account and Remove Account modal if it's a secondary account.
  • View Details button should change to Account Details page.

Screen Shot 2022-06-28 at 1 45 59 PM

@Douglashdaniel Douglashdaniel added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Jun 28, 2022
@Douglashdaniel Douglashdaniel self-assigned this Jun 28, 2022
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Jun 28, 2022
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Sep 8, 2022
Repository owner moved this from In Review to Done in Web3 Sep 24, 2022
@Douglashdaniel Douglashdaniel added this to the 1.46.x - Nightly milestone Oct 17, 2022
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.46.70 Chromium: 107.0.5304.36 (Official Build) beta (64-bit)
Revision 2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS Linux
  • Verified steps from issue description and brave/brave-core#15048
  • Verified new buttons Export, Deposit, Edit, View details, Remove are shown as and when mouse over account name
  • Verified Export asks password prompt before revealing the private key
  • Verified Deposit opens the QR code and address which can be copied to clipboard
  • Verified Edit allows to edit the account name
  • Verified View details loads account details and lists all the visible tokens, transactions for that account
  • Verified Remove is only shown for Imported accounts (Imported secondary and hardware accounts)
  • Verified Remove prompts user account password before removing the account
23743.mp4

Verification passed on

Brave 1.46.70 Chromium: 107.0.5304.36 (Official Build) beta (64-bit)
Revision 2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS Windows 11 Version 22H2 (Build 22621.674)
  • Verified steps from issue description and brave/brave-core#15048
  • Verified new buttons Export, Deposit, Edit, View details, Remove are shown as and when mouse over account name
  • Verified Export asks password prompt before revealing the private key
  • Verified Deposit opens the QR code and address which can be copied to clipboard
  • Verified Edit allows to edit the account name
  • Verified View details loads account details and lists all the visible tokens, transactions for that account
  • Verified Remove is only shown for Imported accounts (Imported secondary and hardware accounts)
  • Verified Remove prompts user account password before removing the account
23743.mp4

Verification passed on

Brave 1.46.70 Chromium: 107.0.5304.36 (Official Build) beta (arm64)
Revision 2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from issue description and brave/brave-core#15048
  • Verified new buttons Export, Deposit, Edit, View details, Remove are shown as and when mouse over account name
  • Verified Export asks password prompt before revealing the private key
  • Verified Deposit opens the QR code and address which can be copied to clipboard
  • Verified Edit allows to edit the account name
  • Verified View details loads account details and lists all the visible tokens, transactions for that account
  • Verified Remove is only shown for Imported accounts (Imported secondary and hardware accounts)
  • Verified Remove prompts user account password before removing the account
23743.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants