Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dismiss wallet interact notification when its not related to tab in focus #23745

Closed
qamarngr opened this issue Jun 28, 2022 · 1 comment · Fixed by brave/brave-core#14009
Closed

Dismiss wallet interact notification when its not related to tab in focus #23745

qamarngr opened this issue Jun 28, 2022 · 1 comment · Fixed by brave/brave-core#14009
Assignees
@qamarngr
Labels
feature/web3/wallet/dapps feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include
Milestone
1.42.x - Release

Comments

@qamarngr
Copy link

qamarngr commented Jun 28, 2022 •
edited
Loading

This is case when the site triggers window.open
@qamarngr qamarngr added OS/Android Fixes related to Android browser functionality feature/web3/wallet Integrating Ethereum+ wallet support feature/web3/wallet/dapps labels Jun 28, 2022
@qamarngr qamarngr self-assigned this Jun 28, 2022
@qamarngr qamarngr changed the title Dismiss notification in when its not related to tab in focus Dismiss wallet interact notification when its not related to tab in focus Jun 28, 2022
@qamarngr qamarngr mentioned this issue Jun 29, 2022
Merged
25 tasks
@SergeyZhukovsky SergeyZhukovsky added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jun 29, 2022
@brave-builds brave-builds added this to the 1.42.x - Nightly milestone Jun 29, 2022
@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 12 running 1.42.80 x64 build

  • Verified steps from brave/brave-core#14009
  • Verified wallet interaction notification is dismissed when tab focus changes
23745.mp4

@srirambv srirambv mentioned this issue Aug 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qamarngr qamarngr

Labels
feature/web3/wallet/dapps feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.42.x - Release
Development

Successfully merging a pull request may close this issue.

dismiss wallet interact notification on newtab for window.open brave/brave-core
5 participants
@bbondy @qamarngr @SergeyZhukovsky @srirambv @brave-builds