Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interacting with Solana Dapp without Solana Account should initiate account creation on the panel #23898

Closed
srirambv opened this issue Jul 6, 2022 · 2 comments · Fixed by brave/brave-core#14221

Comments

@srirambv
Copy link
Contributor

srirambv commented Jul 6, 2022

Description

Interacting with Solana Dapp with Solana Account should probably initiate account creation on the panel

Steps to Reproduce

  1. Clean profile and create Wallet
  2. Visit a Solana Dapp and try to connect
  3. No error shown on UI, but console throws error about WalletConnectionError: An internal error has occurred

Actual result:

Solana Dapp detects provider but doesn't do anything since there is no solana account created

Expected result:

Probably initiate Create Solana Account in Panel and continue to connect to Dapp

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.41.93 Chromium: 103.0.5060.114 (Official Build) (64-bit)
Revision a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS All

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes after 1.41.x is released
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @jamesmudgett @Douglashdaniel

@srirambv srirambv changed the title Interacting with Solana Dapp with Solana Account should probably initiate account creation on the panel Interacting with Solana Dapp without Solana Account should probably initiate account creation on the panel Jul 6, 2022
@jamesmudgett
Copy link

Yes, for existing accounts. Though we may need to find a better solution as discussed in Slack to generate Solana account numbers on new wallet creation. Show/hide when needed.

@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.43.81 Chromium: 104.0.5112.102 (Official Build) (64-bit)
Revision 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS Linux
  • Verified steps from issue description
  • Verified interacting with Solana Dapp opens brave://wallet/crypto/accounts/add-account/create/solana in a new tab to create a Solana Account
  • Verified able to go back to Solana Dapp and connect wallet without having to refresh the page
  • Verified the above works when only Phantom wallet is detected on Dapp
23898-Linux.mp4

Verification passed on

Brave 1.43.81 Chromium: 104.0.5112.102 (Official Build) (64-bit)
Revision 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS Windows 11 Version 21H2 (Build 22000.795)
  • Verified steps from issue description
  • Verified interacting with Solana Dapp opens brave://wallet/crypto/accounts/add-account/create/solana in a new tab to create a Solana Account
  • Verified able to go back to Solana Dapp and connect wallet without having to refresh the page
  • Verified the above works when only Phantom wallet is detected on Dapp
23898-Windows.mp4

Verification passed on

Brave 1.43.81 Chromium: 104.0.5112.102 (Official Build) (arm64)
Revision 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS macOS Version 12.4 (Build 21F79)
  • Verified steps from issue description
  • Verified interacting with Solana Dapp opens brave://wallet/crypto/accounts/add-account/create/solana in a new tab to create a Solana Account
  • Verified able to go back to Solana Dapp and connect wallet without having to refresh the page
  • Verified the above works when only Phantom wallet is detected on Dapp
23898-macOS.mov

@bbondy bbondy changed the title Interacting with Solana Dapp without Solana Account should probably initiate account creation on the panel Interacting with Solana Dapp without Solana Account shouldinitiate account creation on the panel Aug 31, 2022
@bbondy bbondy changed the title Interacting with Solana Dapp without Solana Account shouldinitiate account creation on the panel Interacting with Solana Dapp without Solana Account should initiate account creation on the panel Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants