Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Brave Ads logging for frequency capping #23975

Closed
tmancey opened this issue Jul 11, 2022 · 1 comment · Fixed by brave/brave-core#14106
Closed

Improve Brave Ads logging for frequency capping #23975

tmancey opened this issue Jul 11, 2022 · 1 comment · Fixed by brave/brave-core#14106
Assignees
@tmancey
Labels
dev-concern feature/ads OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA/Yes release-notes/exclude
Milestone
1.43.x - Release

Comments

@tmancey
Copy link
Contributor

tmancey commented Jul 11, 2022 •
edited
Loading

Log Opportunity arose to serve... to the console log when an opportunity arose to serve a notification ad, new tab page ad or inline content ad. An opportunity will arise if there were ads to be served before frequency caps are applied.
@tmancey tmancey self-assigned this Jul 11, 2022
@tmancey tmancey mentioned this issue Jul 11, 2022
Merged
25 tasks
@brave-builds brave-builds added this to the 1.43.x - Nightly milestone Jul 11, 2022
@btlechowski
Copy link

Verification passed on

Brave 1.43.63 Chromium: 104.0.5112.81 (Official Build) beta (64-bit)
Revision 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS Ubuntu 18.04 LTS VM

notification ad

[8385:8385:0816/235646.215400:VERBOSE1:notification_ad.cc(132)] Opportunity arose to serve a notification ad

NTP SI

Verified the log is shown when serving an ad:

[7653:7653:0816/235024.157903:VERBOSE1:new_tab_page_ad.cc(61)] Opportunity arose to serve a new tab page ad

inline ad

[8385:8385:0816/235804.208886:VERBOSE1:inline_content_ad.cc(66)] Opportunity arose to serve an inline content ad

@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
dev-concern feature/ads OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA/Yes release-notes/exclude
Projects
Ads
Archived in project
Milestone
1.43.x - Release
Development

Successfully merging a pull request may close this issue.

Improve Brave Ads logging for frequency capping brave/brave-core
3 participants
@tmancey @btlechowski @brave-builds