Remove `std::function<>` from the `Ledger::GetExternalWallet()` flow #24108

szilardszaloki · 2022-07-18T16:31:28Z

Part2 of #18560.

GeetaSarvadnya · 2022-08-10T09:51:05Z

Verification PASSED on


Brave | 1.43.63 Chromium: 104.0.5112.81 (Official Build) beta (64-bit)
-- | --
Revision | 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS | Windows 10 Version 21H2 (Build 19044.1889)

Verified the test plan from Removes std::function<> from the Ledger::GetExternalWallet() flow. brave-core#14218

Uphold custodian_PASSED

Confirmed Uphold linking with brave wallet works as exepcted
Confirmed that claimed vBAT is moved to Uphold wallet and balance is shown in the wallet
Confirmed userdrain works as expected
Confirmed after claiming vBAT, balance is reflected in rewards settings page, BR panel, Monthly statement and brave://rewards-internals page

Example	Example	Example	Example	Example

vBAT drain event logs:

claimed vBAT is reflected in the transaction history in the uphold wallet:

Console logs for drain id after userdrain was successful:

[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v1/promotions?migrate=true&paymentId=0235e4aa-8491-4010-b82b-bea6d81d...&platform=windows
> Method: GET
...
[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v2/suggestions/claim
> Method: POST
> Content: {"credentials":[{"publicKey":"spo9H...v5tlGTCt9ot8w=="}],"paymentId":"0235e4aa-8491-4010-b82b-bea6d81d..."}
> Content Type: application/json; charset=utf-8
> Header digest: SHA-256=HJlIPmpEMi6BOUuchcAoqPjS0HDErU+Tu8Gn8GTGUdw=
> Header signature: keyId="0235e4aa-8491-4010-b82b-bea6d81dcefa",algorithm="ed25519",headers="digest (request-target)",signature="w3yvFN/l+AObCReGRq41Ndnw2V4mG6FXOkmWbrdVw5nXunQIYn4BeieOQeVPpEROYM8CboGCZ8kQEHhzhw4DCA=="
> Header accept: application/json
[19988:6248:0810/170700.401:VERBOSE6:logging_util.cc(137)]
[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v2/suggestions/claim
> Result: Success
> HTTP Code: 200
> Body: {"drainId":"1946e1da-9128-48cb-8e98-8bcc2f3629f3"}

[19988:6248:0810/170700.402:VERBOSE9:logging_util.cc(138)]
[ RESPONSE HEADERS ]
> Url: https://grant.rewards.bravesoftware.com/v2/suggestions/claim

> Header content-encoding: gzip
> Header content-type: application/json
> Header date: Wed, 10 Aug 2022 11:37:00 GMT
> Header request-id: cbppgn277qbi6i9grg80
> Header server: nginx
> Header vary: Accept-Encoding
> Header via: 1.1 ab8ea6deedbd5a43d4532a9469070864.cloudfront.net (CloudFront)
> Header x-amz-cf-id: nqx0dKfDRL9bDVJSSoKLkv9MF979B15WEdPsXVZaGrKzeQIjy9_KSw==
> Header x-amz-cf-pop: MAA51-P3
> Header x-cache: Miss from cloudfront
> Header x-request-id: xDgcdZbYsxX9sHJj
[19988:6248:0810/170700.488:VERBOSE6:logging_util.cc(137)]
[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v2/suggestions/claim
> Result: Success
> HTTP Code: 200
> Body: {"drainId":"d61a9cb2-3988-406b-a583-658ed63c1112"}

bitFlyer custodian_PASSED

Confirmed bitFlyer linking with brave wallet works as exepcted
Confirmed that claimed vBAT is moved to Uphold wallet and balance is shown in the wallet
Confirmed userdrain works as expected
Confirmed after claiming vBAT, balance is reflected in rewards settings page, BR panel, Monthly statement and brave://rewards-internals page

Example	Example	Example	Example	Example

vBAT drain event logs:

Console logs for drain id after userdrain was successful:

[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v2/suggestions/claim
> Method: POST
> Content: {"credentials":[{"publicKey":"CvFr2wqN4SFWM.....=="}],"paymentId":"1bdf6fa5-801d-493f-959a-b8413ad2..."}
> Content Type: application/json; charset=utf-8
> Header digest: SHA-256=2clMKlouXiI184m/NsJDJON17I670Nivb5LvcasahVY=
> Header signature: keyId="1bdf6fa5-801d-493f-959a-b8413ad2c7b0",algorithm="ed25519",headers="digest (request-target)",signature="j547HELXMCZv/eM5mknotAWhmiHom8PtNKt+ekQHiN9e1RDLre0VXvXzr9ftUb6VlgITaNeSC7rmdY/7o2JQBA=="
> Header accept: application/json
[4348:5812:0812/152250.352:VERBOSE2:tab_manager.cc(159)] Tab id 708671184 HTML content changed
[4348:5812:0812/152250.359:VERBOSE1:conversions.cc(237)] URL is not supported for conversions
[4348:5812:0812/152250.360:VERBOSE2:tab_manager.cc(143)] Tab id 708671184 text content changed
[4348:5812:0812/152250.361:VERBOSE1:purchase_intent_processor.cc(240)] chrome scheme is not supported for processing purchase intent
[4348:5812:0812/152250.362:VERBOSE1:text_classification_processor.cc(105)] chrome scheme is not supported for processing text content
[4348:5812:0812/152251.057:VERBOSE6:logging_util.cc(137)]
[ RESPONSE - OnRequest ]
> Url: https://demo24kiuw4dcyncsy3qlud8u8.azurewebsites.net/api/link/v1/account/inventory
> Result: Success
> HTTP Code: 200
> Body: {
  "account_hash": "2f6ef29a6ffde160b1d28c7fdec78cc00f8f0423",
  "inventory": [
    {
      "currency_code": "JPY",
      "amount": 0.0,
      "available": 0.0
    },
    {
      "currency_code": "BTC",
      "amount": 0.0,
      "available": 0.0
    },
    {
      "currency_code": "BCH",
      "amount": 0.0,
      "available": 0.0
    },
    {
      "currency_code": "ETH",
      "amount": 0.0,
      "available": 0.0
    },
    {
      "currency_code": "ETC",
      "amount": 0.0,
      "available": 0.0
    },
    {
      "currency_code": "LTC",
      "amount": 0.0,
      "available": 0.0
    },
    {
      "currency_code": "MONA",
      "amount": 0.0,
      "available": 0.0
    },
    {
      "currency_code": "LSK",
      "amount": 0.0,
      "available": 0.0
    },
    {
      "currency_code": "XRP",
      "amount": 0.0,
      "available": 0.0
    },
    {
      "currency_code": "BAT",
      "amount": 99.0,
      "available": 99.000000000000
    },
    {
      "currency_code": "XLM",
      "amount": 0.0,
      "available": 0.0
    },
    {
      "currency_code": "XEM",
      "amount": 0.0,
      "available": 0.0
    },
    {
      "currency_code": "XTZ",
      "amount": 0.0,
      "available": 0.0
    },
    {
      "currency_code": "DOT",
      "amount": 0.0,
      "available": 0.0
    },
    {
      "currency_code": "LINK",
      "amount": 0.0,
      "available": 0.0
    }
  ]
}
[4348:5812:0812/152251.072:VERBOSE9:logging_util.cc(138)]
[ RESPONSE HEADERS ]
> Url: https://demo24kiuw4dcyncsy3qlud8u8.azurewebsites.net/api/link/v1/account/inventory

> Header access-control-expose-headers: Request-Context
> Header cache-control: no-cache
> Header content-encoding: gzip
> Header content-length: 239
> Header content-security-policy: frame-ancestors 'self'
> Header content-type: application/json; charset=utf-8
> Header date: Fri, 12 Aug 2022 09:52:51 GMT
> Header expires: -1
> Header pragma: no-cache
> Header request-context: appId=cid-v1:02b3eb01-bff1-4f38-b89d-aa364dbcbb1a
> Header strict-transport-security: max-age=31536000
> Header x-content-type-options: nosniff
> Header x-frame-options: SAMEORIGIN
> Header x-xss-protection: 1; mode=block
[4348:5812:0812/152251.524:VERBOSE6:logging_util.cc(137)]
[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v2/suggestions/claim
> Result: Success
> HTTP Code: 200
> Body: {"drainId":"95234d79-7e5e-4133-af4e-0cc8a721dbb5"}

[4348:5812:0812/152251.524:VERBOSE9:logging_util.cc(138)]

bitFlyer final balance after the vBAT user drain

[ REQUEST ]
> URL: https://demo24kiuw4dcyncsy3qlud8u8.azurewebsites.net/api/link/v1/account/inventory
> Method: GET
[4348:5812:0812/152257.393:VERBOSE6:logging_util.cc(137)]
[ RESPONSE - OnRequest ]
> Url: https://demo24kiuw4dcyncsy3qlud8u8.azurewebsites.net/api/link/v1/account/inventory
> Result: Success
> HTTP Code: 200
> Body: {
  "account_hash": "2f6ef29a6ffde160b1d28c7fdec78cc00f8f0423",
  "inventory": [
    {
      "currency_code": "JPY",
      "amount": 0.0,
      "available": 0.0
    },
    {
      "currency_code": "BTC",
      "amount": 0.0,
      "available": 0.0
    },
    {
      "currency_code": "BCH",
      "amount": 0.0,
      "available": 0.0
    },
    {
      "currency_code": "ETH",
      "amount": 0.0,
      "available": 0.0
    },
    {
      "currency_code": "ETC",
      "amount": 0.0,
      "available": 0.0
    },
    {
      "currency_code": "LTC",
      "amount": 0.0,
      "available": 0.0
    },
    {
      "currency_code": "MONA",
      "amount": 0.0,
      "available": 0.0
    },
    {
      "currency_code": "LSK",
      "amount": 0.0,
      "available": 0.0
    },
    {
      "currency_code": "XRP",
      "amount": 0.0,
      "available": 0.0
    },
    {
      "currency_code": "BAT",
      "amount": 101.0,
      "available": 101.000000000000
    },
    {
      "currency_code": "XLM",
      "amount": 0.0,
      "available": 0.0
    },
    {
      "currency_code": "XEM",
      "amount": 0.0,
      "available": 0.0
    },
    {
      "currency_code": "XTZ",
      "amount": 0.0,
      "available": 0.0
    },
    {
      "currency_code": "DOT",
      "amount": 0.0,
      "available": 0.0
    },
    {
      "currency_code": "LINK",
      "amount": 0.0,
      "available": 0.0
    }
  ]
}
[4348:5812:0812/152257.408:VERBOSE9:logging_util.cc(138)]

Gemini custodian_PASSED

Confirmed Gemini linking with brave wallet works as exepcted
Confirmed that claimed vBAT is moved to Uphold wallet and balance is shown in the wallet
Confirmed userdrain works as expected
Confirmed after claiming vBAT, balance is reflected in rewards settings page, BR panel, Monthly statement and brave://rewards-internals page

Example	Example	Example	Example	Example

vBAT drain event logs:

Console logs for drain id after userdrain was successful:


[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v2/suggestions/claim
> Method: POST
> Content: {"credentials":[{"publicKey":"IIhsAxc8EXO6l2aNgaE6bWr9Uvu......"}],"paymentId":"91377869-171a-4027-8f9d-d0e69ab6..."}
> Content Type: application/json; charset=utf-8
> Header digest: SHA-256=AqtedgYLijMpPpZF31kUy3B0szRLekpxS1NWGeYkZRs=
> Header signature: keyId="91377869-171a-4027-8f9d-d0e69ab66c02",algorithm="ed25519",headers="digest (request-target)",signature="/I1tYosX0WcBS7+wNuCtv/+u3UuV/f9S1T9ErZM3Q/a1nNjjNmWA1cC8ROI6xROeyyhBuEtWWefphpMwDwvFBg=="
> Header accept: application/json
[19416:9352:0812/120625.762:VERBOSE6:logging_util.cc(137)]
[ RESPONSE - OnRequest ]
> Url: https://api.sandbox.gemini.com/v1/balances
> Result: Success
> HTTP Code: 200
> Body: [{"type":"exchange","currency":"USD","amount":"100000.00","available":"100000.00","availableForWithdrawal":"100000.00"},{"type":"exchange","currency":"BAT","amount":"1473.75","available":"1473.75","availableForWithdrawal":"1473.75"},{"type":"exchange","currency":"BTC","amount":"1000","available":"1000","availableForWithdrawal":"1000"},{"type":"exchange","currency":"LTC","amount":"20000","available":"20000","availableForWithdrawal":"20000"},{"type":"exchange","currency":"ZEC","amount":"20000","available":"20000","availableForWithdrawal":"20000"},{"type":"exchange","currency":"BCH","amount":"20000","available":"20000","availableForWithdrawal":"20000"},{"type":"exchange","currency":"ETH","amount":"20000","available":"20000","availableForWithdrawal":"20000"}]
[19416:9352:0812/120625.763:VERBOSE9:logging_util.cc(138)]
[ RESPONSE HEADERS ]
> Url: https://api.sandbox.gemini.com/v1/balances

> Header content-length: 765
> Header content-type: application/json
> Header date: Fri, 12 Aug 2022 06:36:28 GMT
> Header server: nginx
> Header vary: Origin
[19416:9352:0812/120626.378:VERBOSE6:logging_util.cc(137)]
[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v2/suggestions/claim
> Result: Success
> HTTP Code: 200
> Body: {"drainId":"fe4922e7-4eff-47de-9855-6b1170a24d81"}

[19416:9352:0812/120626.379:VERBOSE9:logging_util.cc(138)]

Gemini final balance after the vBAT user drain

[ REQUEST ]
> URL: https://api.sandbox.gemini.com/v1/balances
> Method: POST
[19416:9352:0812/121702.155:VERBOSE6:logging_util.cc(137)]
[ RESPONSE - OnRequest ]
> Url: https://api.sandbox.gemini.com/v1/balances
> Result: Success
> HTTP Code: 200
> Body: [{"type":"exchange","currency":"USD","amount":"100000.00","available":"100000.00","availableForWithdrawal":"100000.00"},{"type":"exchange","currency":"BTC","amount":"1000","available":"1000","availableForWithdrawal":"1000"},{"type":"exchange","currency":"LTC","amount":"20000","available":"20000","availableForWithdrawal":"20000"},{"type":"exchange","currency":"ZEC","amount":"20000","available":"20000","availableForWithdrawal":"20000"},{"type":"exchange","currency":"BCH","amount":"20000","available":"20000","availableForWithdrawal":"20000"},{"type":"exchange","currency":"BAT","amount":"1475.75","available":"1475.75","availableForWithdrawal":"1475.75"},{"type":"exchange","currency":"ETH","amount":"20000","available":"20000","availableForWithdrawal":"20000"}]
[19416:9352:0812/121702.156:VERBOSE9:logging_util.cc(138)]

Additional checks

Confirmed users can send a one-time tip/recurring tip via Uphold/Gemini/bitFlyer custodians
Confirmed users can perform the auto-contribution using vBAT via Uphold custodian

`Uphold`	`Gemini`	`bitFlyer`

GeetaSarvadnya · 2022-08-11T04:45:58Z

Unable to login Gemini accounts and claim ad grants on bitFlyer is throwing error. Adding QA block until these issues resolved

cc: @LaurenWags @Miyayes

LaurenWags · 2022-08-23T15:26:02Z

Verification in progress with

Brave | 1.43.79 Chromium: 104.0.5112.102 (Official Build) beta (x86_64)
-- | --
Revision | 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS | macOS Version 12.5.1 (Build 21G83)

Verified the test plan from Removes std::function<> from the Ledger::GetExternalWallet() flow. brave-core#14218

Gemini - PASSED

Confirmed Gemini linking with brave wallet works as expected
Confirmed userdrain works as expected
Confirmed that claimed vBAT is moved to Gemini wallet and balance is shown in the wallet (note, waiting period with Gemini)
Confirmed balance is updated as expected in UI (brave://rewards, panel, NTP, brave://rewards-internals)

Ad Grant	Ad Grant	Balance after claiming

Balance after successfully linking Gemini	Balance after userdrain is successful	brave://rewards-internals	Gemini site

vBAT drain event logs:

Console logs for drain id after userdrain was successful:

[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v2/suggestions/claim
> Method: POST
> Content: {"credentials":[{"publicKey":"XmRI5........
> Url: https://grant.rewards.bravesoftware.com/v2/suggestions/claim
> Result: Success
> HTTP Code: 200
> Body: {"drainId":"40ef6098-bc15-4be9-ba9a-278da586881d"}

Gemini final balance after the vBAT user drain

[ REQUEST ]
> URL: https://api.sandbox.gemini.com/v1/balances
> Method: POST
[3927:259:0823/154533.191569:VERBOSE6:logging_util.cc(137)] 
[ RESPONSE - OnRequest ]
> Url: https://api.sandbox.gemini.com/v1/balances
> Result: Success
> HTTP Code: 200
> Body: [...........{"type":"exchange","currency":"BAT","amount":"1501.5",............

Uphold - PASSED

Confirmed Uphold linking with brave wallet works as expected
Confirmed userdrain works as expected
Confirmed that claimed vBAT is moved to Uphold wallet and balance is shown in the wallet
Confirmed balance is updated as expected in UI (brave://rewards, panel, NTP, brave://rewards-internals)

Ad Grant	Ad Grant	Balance after claiming

Uphold linking and user drain balance	brave://rewards-internals	Uphold site

vBAT drain event logs:

Console logs for drain id after userdrain was successful:

[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v2/suggestions/claim
> Method: POST
> Content: {"credentials":[{"publicKey":"/sCMQ3..............
[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v2/suggestions/claim
> Result: Success
> HTTP Code: 200
> Body: {"drainId":"aaa24543-2f3d-4406-a25b-2bd0e75bc98d"}

Uphold final balance after the vBAT user drain

[ REQUEST ]
> URL: https://api-sandbox.uphold.com/v0/me/cards/08.............6fd
> Method: GET
[4676:259:0823/162710.225838:VERBOSE6:logging_util.cc(137)] 
[ RESPONSE - OnRequest ]
> Url: https://api-sandbox.uphold.com/v0/me/cards/08...........6fd
> Result: Success
> HTTP Code: 200
> Body: {.........."available":"13.5","balance":"13.5","currency":"BAT","id":"08..............

bitFlyer - PASSED

Confirmed bitFlyer linking with brave wallet works as expected
Confirmed userdrain works as expected
Confirmed that claimed vBAT is moved to bitFlyer wallet and balance is shown in the wallet
Confirmed balance is updated as expected in UI (brave://rewards, panel, NTP, brave://rewards-internals)

Ad Grant	Ad Grant	Balance after claiming

bF linking and user drain balance	brave://rewards-internals	bF site

vBAT drain event logs:

Console logs for drain id after userdrain was successful:

[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v2/suggestions/claim
> Method: POST
> Content: {"credentials":[{"publicKey":"gmeV+SojMGlog9n5...........
[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v2/suggestions/claim
> Result: Success
> HTTP Code: 200
> Body: {"drainId":"46ac6d15-708f-4a6d-b153-15fd82ed21c8"}

bitFlyer final balance after the vBAT user drain

[ REQUEST ]
> URL: https://demo24kiuw4dcyncsy3qlud8u8.azurewebsites.net/api/link/v1/account/inventory
> Method: GET
[5202:259:0823/170028.061897:VERBOSE6:logging_util.cc(137)] 
[ RESPONSE - OnRequest ]
> Url: https://demo24kiuw4dcyncsy3qlud8u8.azurewebsites.net/api/link/v1/account/inventory
> Result: Success
> HTTP Code: 200
> Body: {
  "account_hash": "73949ab............
.........
    {
      "currency_code": "BAT",
      "amount": 96.8,
      "available": 96.800000000000
    },
...........

Uni-verse · 2022-08-30T21:08:07Z

Verified on Samsung Galaxy S21 using the following build(s):

Brave	1.43.84 Chromium: 105.0.5195.68 (Official Build) (64-bit) 
Revision	ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
OS	Android 12; Build/SP1A.210812.016

Test Plan based on brave/brave-core#14218

Gemini

Confirmed Gemini linking with brave wallet works as expected
Confirmed userdrain works as expected
Confirmed that claimed vBAT is moved to Gemini wallet and balance is shown in the wallet (note, waiting period with Gemini)
Confirmed balance is updated as expected in UI (brave://rewards, panel, brave://rewards-internals)

1	2	3

Uphold

Confirmed Uphold linking with brave wallet works as expected
Confirmed userdrain works as expected
Confirmed that claimed vBAT is moved to Gemini wallet and balance is shown in the wallet (note, waiting period with Gemini)
Confirmed balance is updated as expected in UI (brave://rewards, panel, brave://rewards-internals)

1	2	3	4	5	6

bitFlyer

Confirmed bitFlyer linking with brave wallet works as expected
Confirmed userdrain works as expected
Confirmed that claimed vBAT is moved to Gemini wallet and balance is shown in the wallet (note, waiting period with Gemini)
Confirmed balance is updated as expected in UI (brave://rewards, panel, brave://rewards-internals)

1	2	3	4	5	6

btlechowski · 2022-09-01T13:06:56Z

Verification passed on

Brave	1.43.88 Chromium: 105.0.5195.68 (Official Build) (64-bit)
Revision	ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
OS	Ubuntu 18.04 LTS

Verified the test plan from Removes std::function<> from the Ledger::GetExternalWallet() flow. brave-core#14218

Gemini - PASSED

Confirmed Gemini linking with brave wallet works as expected
Confirmed userdrain works as expected
Confirmed that claimed vBAT is moved to Gemini wallet and balance is shown in the wallet (note, waiting period with Gemini)
Confirmed balance is updated as expected in UI (brave://rewards, panel, NTP, brave://rewards-internals)

Ad Grant	Ad Grant	Balance after claiming

After linking

vBAT drain event logs:

Console logs for drain id after userdrain was successful:

[ REQUEST ]
> URL: https://grant.rewards.bravesoftware.com/v2/suggestions/claim
> Method: POST
> Content: {"credentials":[{"publicKey":"WNbOpSKV68gOBVnMEqt0Oqnb+DYTn


[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v2/suggestions/claim
> Result: Success
> HTTP Code: 200
> Body: {"drainId":"9b7ea823-27d5-4960-a5fb-73b6da154b6b"}

Gemini final balance after the vBAT user drain

[ RESPONSE - OnRequest ]
> Url: https://api.sandbox.gemini.com/v1/balances
> Result: Success
> HTTP Code: 200
> Body: [{"type":"exchange","currency":"BAT","amount":"1502","available":"1502","availableForWithdrawal":"1502"},

Uphold - PASSED

Confirmed Uphold linking with brave wallet works as expected
Confirmed userdrain works as expected
Confirmed that claimed vBAT is moved to Uphold wallet and balance is shown in the wallet
Confirmed balance is updated as expected in UI (brave://rewards, panel, NTP, brave://rewards-internals)

Ad Grant	Ad Grant	Balance after claiming

after linking

vBAT drain event logs:

Console logs for drain id after userdrain was successful:

[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v2/suggestions/claim
> Result: Success
> HTTP Code: 200
> Body: {"drainId":"79b96335-b9c9-4982-af97-0ab6d6abb0c3"}

Uphold final balance after the vBAT user drain

[ RESPONSE - OnRequest ]
> Url: https://api-sandbox.uphold.com/v0/me/cards/c8efcc83-749d-4fa8-a5e8-6be943518eb4
> Result: Success
> HTTP Code: 200
> Body: {"CreatedByApplicationId":"193a77cf-02e8-4e10-8127-8a1b5a8bfece","address":{"wire":"UH38EFC9B9"},"available":"2.00","balance":"2.00","currency":"BAT","id":"c8efcc83-749d-4fa8-a5e8-6be943518eb4","label":"Brave Browser","

bitFlyer - PASSED

Confirmed bitFlyer linking with brave wallet works as expected
Confirmed userdrain works as expected
Confirmed that claimed vBAT is moved to bitFlyer wallet and balance is shown in the wallet
Confirmed balance is updated as expected in UI (brave://rewards, panel, NTP, brave://rewards-internals)

Ad Grant	Ad Grant	Balance after claiming

after linking

vBAT drain event logs:

Console logs for drain id after userdrain was successful:

[ RESPONSE - OnRequest ]
> Url: https://grant.rewards.bravesoftware.com/v2/suggestions/claim
> Result: Success
> HTTP Code: 200
> Body: {"drainId":"1baecf77-cf29-4aa6-b438-ff10c4963548"}

bitFlyer final balance after the vBAT user drain

[ RESPONSE - OnRequest ]
> Url: https://demo24kiuw4dcyncsy3qlud8u8.azurewebsites.net/api/link/v1/account/inventory
> Result: Success
> HTTP Code: 200
> Body: {
  "account_hash": "0c2d0b37e33da34cc82d8659ff8110d8095b9bd3",
  "inventory": [
    {
      "currency_code": "BAT",
      "amount": 102.0,
      "available": 102.000000000000
    },

szilardszaloki added dev-concern QA/Yes release-notes/exclude OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality labels Jul 18, 2022

szilardszaloki self-assigned this Jul 18, 2022

This was referenced Jul 18, 2022

Switching from std::function<> to base::OnceCallback<>. #18560

Open

Removes std::function<> from the Ledger::GetExternalWallet() flow. brave/brave-core#14218

Merged

szilardszaloki closed this as completed in brave/brave-core#14218 Jul 20, 2022

brave-builds added this to the 1.43.x - Nightly milestone Jul 20, 2022

LaurenWags added the QA/Test-All-Platforms label Aug 8, 2022

GeetaSarvadnya added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Aug 10, 2022

LaurenWags added the feature/rewards label Aug 10, 2022

GeetaSarvadnya added the QA/Blocked label Aug 11, 2022

GeetaSarvadnya added QA Pass-Win64 and removed QA/Blocked QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Aug 12, 2022

LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Aug 23, 2022

LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Aug 23, 2022

GeetaSarvadnya mentioned this issue Aug 24, 2022

Remove std::function<> from the Ledger::FetchBalance() flow #24051

Closed

LaurenWags mentioned this issue Aug 24, 2022

Remove std::function<> from further Ledger flows #24200

Closed

Uni-verse added the QA Pass - Android ARM label Aug 30, 2022

btlechowski added the QA Pass-Linux label Sep 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove `std::function<>` from the `Ledger::GetExternalWallet()` flow #24108

Remove `std::function<>` from the `Ledger::GetExternalWallet()` flow #24108

szilardszaloki commented Jul 18, 2022

GeetaSarvadnya commented Aug 10, 2022 •

edited

Loading

GeetaSarvadnya commented Aug 11, 2022 •

edited

Loading

LaurenWags commented Aug 23, 2022 •

edited

Loading

Uni-verse commented Aug 30, 2022 •

edited

Loading

btlechowski commented Sep 1, 2022

Remove std::function<> from the Ledger::GetExternalWallet() flow #24108

Remove std::function<> from the Ledger::GetExternalWallet() flow #24108

Comments

szilardszaloki commented Jul 18, 2022

GeetaSarvadnya commented Aug 10, 2022 • edited Loading

Additional checks

GeetaSarvadnya commented Aug 11, 2022 • edited Loading

LaurenWags commented Aug 23, 2022 • edited Loading

Uni-verse commented Aug 30, 2022 • edited Loading

btlechowski commented Sep 1, 2022

Remove `std::function<>` from the `Ledger::GetExternalWallet()` flow #24108

Remove `std::function<>` from the `Ledger::GetExternalWallet()` flow #24108

GeetaSarvadnya commented Aug 10, 2022 •

edited

Loading

GeetaSarvadnya commented Aug 11, 2022 •

edited

Loading

LaurenWags commented Aug 23, 2022 •

edited

Loading

Uni-verse commented Aug 30, 2022 •

edited

Loading