-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Sync] Warn if OS Keychain is locked or impossible to decrypt sync code words #24121
Labels
Milestone
Comments
AlexeyBarabash
added
feature/sync
OS/Android
Fixes related to Android browser functionality
OS/Desktop
labels
Jul 19, 2022
25 tasks
7 tasks
kjozwiak
added
OS/Linux
OS/macOS
and removed
OS/Android
Fixes related to Android browser functionality
labels
Aug 29, 2022
The above will require |
stephendonner
added
the
QA/In-Progress
Indicates that QA is currently in progress for that particular issue
label
Aug 30, 2022
Verification
|
Brave | 1.43.84 Chromium: 105.0.5195.68 (Official Build) (x86_64) |
---|---|
Revision | ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903} |
OS | macOS Version 11.6.8 (Build 20G730) |
Followed Kamil's modified testplan: brave/brave-core#14224 (comment)
Steps:
- installed
1.43.84
- launched Brave
- loaded
brave://sync-internals
- ensured
Passphrase is set
was set tofalse
- ensured
OS encryption available
was set totrue
- loaded
brave://sync/
- clicked on
Start using sync
- clicked on
Start a new Sync Chain
- click on
Computer
- click
OK
- loaded
brave://sync-internals/
- confirmed
Passphrase is set
istrue
- confirmed
OS encryption available
istrue
- shut down Brave
- removed
Brave Browser
access to theBrave Safe Storage
usingKeychain Access
- launched Brave
- loaded
brave://sync-internals
- ensured
Passphrase is set
istrue
- ensured
Passphrase decryption failed
istrue
- ensured
OS encryption available
isfalse
- confirmed I got the
Sync service could not be started, Sync is not running
notification - confirmed clicking on
Check details
takes me tobrave://settings/braveSync/setup
- confirmed clicking on the troubleshooting link loads
https://support.brave.com/hc/en-us/articles/360047642371-Sync-FAQ
correctly - ensured that the
Sync service could not be started, Sync is not running
notification re-appears when re-launching the browser after dismissing the notification viaX
- ensured that the
Sync service could not be started, Sync is not running
notification re-appears when re-launching the browser after dismissing the notification by clicking onCheck details
- ensured that the
Sync service could not be started, Sync is not running
notification doesn't re-appear when re-launching the browser after the user has dismissed the notification viaDon't show again
. - shut down Brave
- granted
Brave Browser
access to theBrave Safe Storage
viaKeychain Access
- launched Brave
- clicked on
Deny
on theBrave Safe Storage
dialog - load
brave://sync-internals
- confirmed
Passphrase is set
->true
- confirmed
Passphrase decryption failed
->true
- confirmed
OS encryption available
->false
- shut down Brave
- launched Brave
- entered my password for
Keychain Access
and clicked onAlways Allow
on the dialog - added my iPhone via
brave://sync/
and confirmed it's working - loaded
brave://sync-internals
- noted
Passphrase is set
istrue
andOS encryption available
istrue
steps 4-5 | steps 12-13 | step 15 | steps 17-20 | steps 21-22 | step 23 | step 28 | step 30 | steps 31-34 | step 38 | steps 39-40 |
---|---|---|---|---|---|---|---|---|---|---|
Verification passed on
Brave | 1.43.85 Chromium: 105.0.5195.68 (Official Build) (64-bit) |
---|---|
Revision | ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903} |
OS | Ubuntu 18.04 LTS |
Followed Kamil's modified testplan: brave/brave-core#14224 (comment)
Steps:
- installed
1.43.85
- launched Brave
- loaded
brave://sync-internals
- ensured
Passphrase is set
was set tofalse
- ensured
OS encryption available
was set totrue
- loaded
brave://sync/
- clicked on
Start using sync
- clicked on
Start a new Sync Chain
- click on
Computer
- click
OK
- loaded
brave://sync-internals/
- confirmed
Passphrase is set
istrue
- confirmed
OS encryption available
istrue
- shut down Brave
- removed
Brave Browser
access to theBrave Safe Storage
usingKeychain Access
- launched Brave
- loaded
brave://sync-internals
- ensured
Passphrase is set
istrue
- ensured
Passphrase decryption failed
istrue
- ensured
OS encryption available
isfalse
- confirmed I got the
Sync service could not be started, Sync is not running
notification - confirmed clicking on
Check details
takes me tobrave://settings/braveSync/setup
- confirmed clicking on the troubleshooting link loads
https://support.brave.com/hc/en-us/articles/360047642371-Sync-FAQ
correctly - ensured that the
Sync service could not be started, Sync is not running
notification re-appears when re-launching the browser after dismissing the notification viaX
- ensured that the
Sync service could not be started, Sync is not running
notification re-appears when re-launching the browser after dismissing the notification by clicking onCheck details
- ensured that the
Sync service could not be started, Sync is not running
notification doesn't re-appear when re-launching the browser after the user has dismissed the notification viaDon't show again
. - shut down Brave
- granted
Brave Browser
access to theBrave Safe Storage
viaKeychain Access
- launched Brave
- clicked on
Deny
on theBrave Safe Storage
dialog - load
brave://sync-internals
- confirmed
Passphrase is set
->true
- confirmed
Passphrase decryption failed
->true
- confirmed
OS encryption available
->false
- shut down Brave
- launched Brave
- entered my password for
Keychain Access
and clicked onAlways Allow
on the dialog - added another device via
brave://sync/
and confirmed it's working - loaded
brave://sync-internals
- noted
Passphrase is set
istrue
andOS encryption available
istrue
steps 4-5 | steps 12-13 | step 15 | steps 17-20 | steps 21-22 | step 23 | step 30 | steps 31-34 | step 38 | steps 39-40 |
---|---|---|---|---|---|---|---|---|---|
stephendonner
added
QA Pass-macOS
and removed
QA/In-Progress
Indicates that QA is currently in progress for that particular issue
labels
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
If OS Keychain is locked and/or impossible to decrypt sync code words, then sync doesn't work.
Also there is a crash when trying to display QR code.
Steps to reproduce:
Actual - there is one word.
Expected not to have any words.
Actual - crash happens
Expected not to crash at least.
Required:
Reproduced on Ubuntu and macOS.
The text was updated successfully, but these errors were encountered: