Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search the web privately is not translated on NTP Private Window/Tor #24267

Closed
btlechowski opened this issue Jul 26, 2022 · 5 comments · Fixed by brave/brave-core#14463
Closed
Assignees

Comments

@btlechowski
Copy link

btlechowski commented Jul 26, 2022

Follow up to #23732

Steps to Reproduce

  1. launch Brave in PL (Polish) locale
  2. click hamburger menu
  3. opened a new Private Window with Tor
    OR opened a new Private Window
    OR opened a new Guest Window

Actual result:

Search with web privately is not translated

image image image

Expected result:

Search the web privately is translated

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.42.74 Chromium: 103.0.5060.134 (Official Build) beta (64-bit)
Revision a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS Ubuntu 18.04 LTS

cc @rebron @mkarolin @brave/qa-team @nullhook

@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jul 26, 2022
@mkarolin
Copy link
Contributor

I don't see this string in any of the GRD(P) files. It seems to be hardcoded at the moment in components/brave_private_new_tab_ui/resources/page/components/search-box/index.tsx:166 (maybe?) cc: @nullhook

@simonhong
Copy link
Member

simonhong commented Jul 27, 2022

@nullhook Please handling here(https://github.com/brave/brave-core/blob/master/components/brave_new_tab_ui/components/default/searchPromotion/searchBox.tsx#L130) together.
I referenced your search box for ntp promotion and has same issue.(placeholder text)

@kjozwiak
Copy link
Member

We'll need translations to be able to verify the above. Once we get the translations uplifted into 1.43.x, the above can be checked. I did run through a quick sanity check and made sure string is still being displayed and nothing obvious regressed as per brave/brave-core#14463 (comment).

@LaurenWags
Copy link
Member

Testing can be completed with 1.43.84 and above as translations have been included in that version.

@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Aug 30, 2022
@stephendonner
Copy link

stephendonner commented Aug 30, 2022

Verified PASSED using

Brave 1.43.84 Chromium: 105.0.5195.68 (Oficjalna wersja) (x86_64)
Wersja ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
System operacyjny macOS Wersja 11.6.8 (kompilacja 20G730)

Followed original steps to reproduce; confirmed the Search the web privately string has been translated.

Polish

Private window Private window w/Tor Guest window
Zrzut ekranu 2022-08-30 o 08 47 26 Zrzut ekranu 2022-08-30 o 08 47 36 Zrzut ekranu 2022-08-30 o 08 47 45

French

Private window Private window w/Tor Guest window
Capture d’écran 2022-08-30 à 08 55 14 Capture d’écran 2022-08-30 à 08 55 44 Capture d’écran 2022-08-30 à 08 55 54

Hindi

Private window Private window w/Tor Guest window
स्क्रीन शॉट 2022-08-30, पू 9 00 52 पर स्क्रीन शॉट 2022-08-30, पू 9 01 01 पर स्क्रीन शॉट 2022-08-30, पू 9 01 08 पर

@stephendonner stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants