-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search the web privately
is not translated on NTP Private Window/Tor
#24267
Comments
I don't see this string in any of the GRD(P) files. It seems to be hardcoded at the moment in components/brave_private_new_tab_ui/resources/page/components/search-box/index.tsx:166 (maybe?) cc: @nullhook |
@nullhook Please handling here(https://github.com/brave/brave-core/blob/master/components/brave_new_tab_ui/components/default/searchPromotion/searchBox.tsx#L130) together. |
We'll need translations to be able to verify the above. Once we get the translations uplifted into |
Testing can be completed with 1.43.84 and above as translations have been included in that version. |
Verified
|
Brave | 1.43.84 Chromium: 105.0.5195.68 (Oficjalna wersja) (x86_64) |
---|---|
Wersja | ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903} |
System operacyjny | macOS Wersja 11.6.8 (kompilacja 20G730) |
Followed original steps to reproduce; confirmed the Search the web privately
string has been translated.
Polish
Private window | Private window w/Tor | Guest window |
---|---|---|
French
Private window | Private window w/Tor | Guest window |
---|---|---|
Hindi
Private window | Private window w/Tor | Guest window |
---|---|---|
Follow up to #23732
Steps to Reproduce
Private Window with Tor
OR opened a new
Private Window
OR opened a new
Guest Window
Actual result:
Search with web privately
is not translatedExpected result:
Search the web privately
is translatedReproduces how often:
Easily reproduced
Brave version (brave://version info)
cc @rebron @mkarolin @brave/qa-team @nullhook
The text was updated successfully, but these errors were encountered: