Incorrect Formatting on Trackers & Ads Blocked

[jonathansampson]

Description

The number shown for Trackers & Ads Blocked on the New Tab Page lacks commas.

Steps to Reproduce

1. Use Brave a lot 🙂
2. Visit the New Tab Page

Actual result:

A number like 6011204 is displayed without commas.

Expected result:

A number like 6011204 is displayed according to the user's locale. For example, en-US users should see 6,011,204.

Reproduces how often:

Always.

Brave version (brave://version info)

1.42.86

Version/Channel Information:

• Can you reproduce this issue with the current release? Yes
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

[jonathansampson]

Looks like the difference between numbers and strings; perhaps we recently switched types:

[jonathansampson]

Looks like this is where the behavior changed: brave/brave-core@531526b.

[stephendonner]

Verified PASSED using

Brave	1.44.73 Chromium: 105.0.5195.68 (Official Build) beta (x86_64)
Revision	ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
OS	macOS Version 13.0 (Build 22A5331f)

Steps:

1. installed 1.44.73
2. launched Brave
3. visited some sites, to get a profile and populate data
4. shut down Brave
5. found a way to set ads_blocked to 1000000000
6. opened a new-tab page

Confirmed I saw 1,000,000,000 Trackers & ads blocked