Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching for any of the "additional permissions" in settings doesn't take the user to that setting #25055

Open
wknapik opened this issue Aug 29, 2022 · 0 comments

Comments

@wknapik
Copy link
Contributor

wknapik commented Aug 29, 2022

Description

Searching for anything in the Privacy and security -> Site and Shields settings -> Additional permissions section in brave://settings shows the user the contents of the Privacy and security section with a yellow bubble indicating that there are matches under Sites and Shields Settings, but once the user clicks on that section, they end up at brave://settings/content?search=<query> and the setting they were looking for is not visible (*). They have to figure out to click on Additional permissions to see the setting they were looking for (and it will be highlighted in yellow when they expand the section).

The same issue applies to settings under Additional client settings.

(*) The browser appears to remember the collapsed/expanded state for those sections, so if they happen to be expanded, then there's no issue, but if they're collapsed (which is the case in a fresh profile), the issue occurs.

I thought for sure this would already be reported, since the issue has been around for a long time, but I couldn't find an open issue.

Steps to Reproduce

  1. Start with a fresh profile, or one that has Additional permissions collapsed
  2. Go to brave://settings
  3. Hit ^F and search for autoplay (brave://settings/?search=autoplay)
    image
  4. The Site and Shields Settings category will will be highlighted as having two hits for the phrase
  5. Click on Site and Shields Settings (brave://settings/content?search=autoplay)
    image
  6. The Autoplay setting isn't there (the user has to figure out to click on Additional permissions)
    image

Actual result:

The user doesn't see the setting they searched for

Expected result:

The user sees the setting they searched for

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.45.10 Chromium: 105.0.5195.68 (Official Build) nightly (64-bit)
Revision ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? ?

Miscellaneous Information:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant