Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show full network name in transaction confirmation panel (BRA-Q322-3. Misleading Blockchain Names) #25105

Closed
josheleonard opened this issue Aug 31, 2022 · 1 comment · Fixed by brave/brave-core#14924 or brave/brave-core#14979

Comments

@josheleonard
Copy link

josheleonard commented Aug 31, 2022

Description

BRA-Q322-3. Misleading Blockchain Names

Before rendering a blockchain name, Brave Wallet uses the reduceNetworkDisplayName function to reduce the network name.
Such a design decision leads to ambiguity for users and possible unintended transactions. For example, executing transaction on the main network instead of using test network. Users must hover over the blockchain name to be sure on which network they will be executing transactions.

Steps to Reproduce

  1. Enable displaying test networks from Wallet setting
  2. Unlock the desktop version of the Brave Wallet
  3. Select Ropsten Testnet
  4. Send ETH from one account to another
  5. Notice that the network name is not fully displayed

Actual result:

Screen Shot 2022-08-31 at 11 30 42 AM

Expected result:

Screen Shot 2022-08-31 at 11 33 25 AM

Reproduces how often:

Easy

@srirambv
Copy link
Contributor

Verified as part of #25114 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment