Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect response value when Brave VPN usage days (30 days) distributed within two months #25220

Closed
GeetaSarvadnya opened this issue Sep 5, 2022 · 1 comment

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 5, 2022

Description

Found while testing #23892
Incorrect response value when vpn usage days (30 days) distributed within two months

Steps to Reproduce

As Brave VPN user, how many different days did I enable the Brave VPN in the last 30 days?
Brave.VPN.DaysInMonthUsed

  1. Cean profile 1.44.x
  2. Enable VPN today (5th Sep)
  3. Open brave://local-state and ensured the metrics Brave.VPN.DaysInMonthUsed response value is 1 as expected
  4. Close the browser and set the system clock to Oct 1st
  5. Relaunch the browser
  6. Reload brave://local-state and ensured the metrics Brave.VPN.DaysInMonthUsed response value is 2 as expected
  7. Close the browser and set the system clock to Oct 4th
  8. Relaunch the browser
  9. Reload brave://local-state and ensured the metrics Brave.VPN.DaysInMonthUsed response value is 3 as expected
  10. Close the browser and set the system clock to Oct 5th
  11. Relaunch the browser
  12. Reload brave://local-state and ensured the metrics Brave.VPN.DaysInMonthUsed response value is 3 as expected
  13. Close the browser and set the system date to oct 10
  14. Reload brave://local-state and ensured the metrics Brave.VPN.DaysInMonthUsed response value is 3 as expected
  15. Close the browser and set the system date to oct 15, oct 20, oct 30, oct 31 and Nov1
  16. The response value is 3 for all the dates in step 13

Actual result:

Incorrect response value when vpn usage days (30 days) distributed within two months

Expected result:

The reponse value should be calculated for Brave VPN usage for the last 30 days only irrespective of month overlap

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.44.73 Chromium: 105.0.5195.68 (Official Build) beta (64-bit)
Revision ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
OS Windows 10 Version 21H2 (Build 19044.1889)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @DJAndries @mattmcalister @brave/qa-team

@GeetaSarvadnya GeetaSarvadnya changed the title Incorrect response value when vpn usage days (30 days) distributed withing two months Incorrect response value when vpn usage days (30 days) distributed within two months Sep 5, 2022
@GeetaSarvadnya GeetaSarvadnya changed the title Incorrect response value when vpn usage days (30 days) distributed within two months Incorrect response value when Brave VPN usage days (30 days) distributed within two months Sep 5, 2022
@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Sep 7, 2022

The VPN subscription is valid for one month and when I set the date beyond one month, the vpn gets disconnected (show up the paymnet subscription expiry messge) hence the VPN usage is not accounted from the date when it gets disconnected. If I move the dates ahead then VPN usage counts gets decreased as expected.

Issue is working as expected. Hence closing the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant