Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing new-notification icon indicator for "added to reading list" action #25237

Open
stephendonner opened this issue Sep 6, 2022 · 2 comments
Labels
bug feature/sidebar Relating to Brave's Sidebar feature OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA/Test-Plan-Specified QA/Yes release-notes/exclude

Comments

@stephendonner
Copy link

Description

Missing new-notification icon indicator for "added to reading list" action

According to #17959 this should be there (first testcase!)

Steps to Reproduce

  1. install 1.44.73
  2. launch Brave
  3. load theverge.com
  4. right-click on the tab
  5. choose Add Tab to Reading List
  6. look at the side panel toolbar icon

Actual result:

Screenshot 2022-09-06 at 4 44 24 PM

Expected result:

178615070-30b4862b-3fb6-41c3-a140-848f1daa52f7

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.44.73 Chromium: 105.0.5195.68 (Official Build) beta (x86_64)
Revision ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
OS macOS Version 13.0 (Build 22A5331f)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

/cc @rebron @aguscruiz @petemill @GeetaSarvadnya

@aguscruiz
Copy link

Added designs for this on Figma:
https://www.figma.com/file/xOdKFSr3P5AXSAbP2r8ung/Sidebar-Desktop?node-id=4272%3A70774

image

@rebron rebron added priority/P4 Planned work. We expect to get to it "soon". release-notes/exclude labels Sep 9, 2022
@rebron
Copy link
Collaborator

rebron commented Sep 9, 2022

cc: @petemill

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/sidebar Relating to Brave's Sidebar feature OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Development

No branches or pull requests

3 participants