Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn message should be more legible on light theme #25339

Closed
srirambv opened this issue Sep 12, 2022 · 1 comment · Fixed by brave/brave-core#15133
Closed

Warn message should be more legible on light theme #25339

srirambv opened this issue Sep 12, 2022 · 1 comment · Fixed by brave/brave-core#15133
Assignees
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@srirambv
Copy link
Contributor

Description

Missed as part of #21053 verification, checksum invalid message is barely visible on light theme

Steps to Reproduce

  1. Add an invalid checksum address in Send field
  2. Error message is not visible at all when browser is set to light theme
  3. Learn more should also have better top padding with the message

Actual result:

Light Dark
image image

Expected result:

More legible text on any theme

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.43.89 Chromium: 105.0.5195.102 (Official Build) (64-bit)
Revision 4c16f5ffcc2da70ee2600d5db77bed423ac03a5a-refs/branch-heads/5195_55@{#4}
OS Windows 11 Version 21H2 (Build 22000.918)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @Douglashdaniel @supermassive @jamesmudgett

@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.45.104 Chromium: 106.0.5249.126 (Official Build) beta (64-bit)
Revision fb2e06d2dee20fe0c804528502b5ad72c613abd9-refs/branch-heads/5249_118@{#3}
OS Linux
  • Verified steps from issue description and brave/brave-core#15133
  • Verified warning message has better legibility in light theme
Light Dark
image image

Verification passed on

Brave 1.45.104 Chromium: 106.0.5249.126 (Official Build) beta (64-bit)
Revision fb2e06d2dee20fe0c804528502b5ad72c613abd9-refs/branch-heads/5249_118@{#3}
OS Windows 11 Version 21H2 (Build 22000.978)
  • Verified steps from issue description and brave/brave-core#15133
  • Verified warning message has better legibility in light theme
Light Dark
image image

Verification passed on

Brave 1.45.104 Chromium: 106.0.5249.126 (Official Build) beta (arm64)
Revision fb2e06d2dee20fe0c804528502b5ad72c613abd9-refs/branch-heads/5249_118@{#3}
OS macOS Version 12.4 (Build 21F79)
  • Verified steps from issue description and brave/brave-core#15133
  • Verified warning message has better legibility in light theme
Light Dark
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants