Non-referral downloads should use generic refcode #2547
Comments
davidtemkin
assigned aekeus, BrendanEich, diracdeltas, tildelowengrimm, bbondy, kjozwiak, bsclifton, rebron and mandar-brave
|
@anthonypkeane to follow up for Mobile as well - not a high priority immediately. |
|
@jhreis @SergeyZhukovsky Pls add this to the list of to-dos |
|
In case it wasn't clear, we should not do IP or other types of anti-fraud logging for general referrals. (Basically any download not from a referral promo) |
bbondy
added
the
priority/P2
|
@diracdeltas are you ok with keeping the current behaviour of storing the geo-coded country for downloads and installations using the new default refcode? |
|
@aekeus do you mean the current behavior for referral promo builds is to log geo-coded country for each referral download? is the country logged alongside any other information (like IP)? |
|
@diracdeltas ip is not stored, it is geo-coded and the ip address discarded. |
|
if the effect is just "Brave sees country code of all downloads/installs (unlinked to any other data except the user's referral code)" i think that is not necessary to remove, but if it's not needed, it should probably be removed. my general concern is we may want to add more anti-fraud checks in the future for referral promo users that we don't want for regular users, so it might make sense to distinguish between the two from the start. |
|
@diracdeltas ok that makes sense. Would it be better if we removed all info from the iptags JSON blob except country for the default refcode case? |
|
country is needed for reasons other than anti-fraud. good point on being careful wrt on any future anti-fraud measures related to referrals. |
sgtm should/can we also do this for non-default refcodes which are not from referrer promos? (like downloads via co-installers or ad campaigns, which i believe will also use refcodes) |
|
@diracdeltas yes, country is the only identifier required. We should remove the rest on all downloads. Will update the linked issue. |
|
cc: @anthonypkeane |
|
Verification passed on
Used test plan from brave/brave-core#1982
|
|
Marking as Windows and macOS only as referrals are not available on Linux |
|
I think we do want the generic referral code reporting on Linux -- the intent here is to measure our organic download usage, and that does not involve the download/install refcode mechanism. It only requires that the generic "organic" refocode be put into the update pings. (In effect, this will mean all Linux builds will use this one refcode). @srirambv |
|
Removed OS/Windows and OS/macOS labels based on the above comment |
|
Verified on new profile and it shows the default ref code. Existing profiles doesn't show it. Marking it as passed on
Verification passed on
Fiddler- Default Ref code Local state file - Default Ref code
Verified passed with
|
Currently, only versions of Brave that have been downloaded with a refcode (as encoded in the installer's filename) will (a) call referral server endpoints immediately and at 30 days, and (b) will include the refcode in update pings for the first 90 days of usage.
This change will add an implicit, default refcode for all downloads, even those not downloaded via referral links.
Here's the change: All Brave browsers should add a universal "default" Brave refcode into the user profile at first run time (if not already present from a referral download/installation process) and act from that moment forward exactly as any referred download would act.
This will give us apples-to-apples data that will allow us to diagnose potential problems with both "organic" and referred installs.
Stay tuned for the actual default refcode to use.
This change needs to be released in .58.x
The text was updated successfully, but these errors were encountered: