Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave news feed doesn't show when enabled through settings #25500

Closed
Uni-verse opened this issue Sep 20, 2022 · 2 comments · Fixed by brave/brave-core#15153
Closed

Brave news feed doesn't show when enabled through settings #25500

Uni-verse opened this issue Sep 20, 2022 · 2 comments · Fixed by brave/brave-core#15153

Comments

@Uni-verse
Copy link
Contributor

Uni-verse commented Sep 20, 2022

Description

Enabling brave news using the switch in the menu and then navigating back to NTP will still show news modal.

Steps to reproduce

  1. Clean profile
  2. Navigate to menu > Brave News > Enable Show Brave News
  3. Return to NTP

Actual result

Brave News Card is still shown. news feed not shown

news_menu_start01.mp4

Expected result

News feed should be shown

Issue reproduces how often

Always

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? N/A
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Samsung GS 21
  • Android version: 12

Brave version

1.45.x, 1.43.x

@kjozwiak
Copy link
Member

The above requires 1.44.97 or higher for 1.44.x verification 👍

@Uni-verse
Copy link
Contributor Author

Verified on Samsung Galaxy S 21 & Galaxy Tab S7 using the following build(s):

Brave	1.44.97 Chromium: 106.0.5249.55 (Official Build) (64-bit) 
Revision	4d5f098fca6ab7f4b6b7c240be3d9593c2357709-refs/branch-heads/5249@{#531}
OS	Android 12; Build/SP1A.210812.016
  • Ensured news feed is shown immediately after enabling Show Brave News in the Brave News menu.
  • Ensured news feed is not shown if disabled via the settings menu.
  • Ensured that the news feed can be re-enabled after disabling.
25500_fix01.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants