Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore all from deleted publisher doesn't restore all - Follow up to 1441 #2551

Closed
LaurenWags opened this issue Dec 13, 2018 · 1 comment · Fixed by brave/brave-core#921
Closed

Comments

@LaurenWags
Copy link
Member

Description

Follow up to #1441

If you follow steps from #1441 (comment) on a newer version (Release 0.56.x and after), it works because #1440 was resolved in 0.56.x. However, if you had performed the steps from #1441 (comment) on 0.55.x release version, then #1441 does not solve your issue when you update to 0.58.x.

Steps to Reproduce

Pre-requisite - have a Release version of 0.55.x installed (I used 0.55.18)
(steps 1-7 below copied from #1441 (comment))

  1. Visit 7-8 sites to populate the table
  2. Exclude one site (say github.com) from the table
  3. Ensure the exclude site shows as 1 and restore all
  4. Revisit github.com in a new tab or the existing tab
  5. Once min time is met, github.com gets added back to the list
  6. Exclude list still shows 1 excluded site (github.com from step 2)
  7. Restore all doesn't remove the count of excluded sites since github.com got added back to the list from step 5.
  8. Update to 0.58.12 and attempt to 'Restore All'

Actual result:

Nothing happens. You are still stuck with a site you can't restore and you have no way of seeing what this site is.

1441-scenario

Expected result:

All sites should be restored.

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.58.12 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

cc @brave/legacy_qa for verification on other platforms

@LaurenWags
Copy link
Member Author

LaurenWags commented Feb 15, 2019

Verified passed with

Brave 0.60.28 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Mac OS X
  • Verified STR from description

Verification passed on

Brave 0.60.29 Chromium: 72.0.3626.96 (Official Build) beta (64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Windows 7

Used STR from the description.

Verification passed on

Brave 0.60.40 Chromium: 72.0.3626.109 (Official Build) (64-bit)
Revision fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS Linux
  • Verified steps from issue description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants