Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tip button on GitHub org people page doesn't work #25528

Closed
mkarolin opened this issue Sep 21, 2022 · 3 comments
Closed

Tip button on GitHub org people page doesn't work #25528

mkarolin opened this issue Sep 21, 2022 · 3 comments

Comments

@mkarolin
Copy link
Contributor

mkarolin commented Sep 21, 2022

STR:

  1. Navigate to a GitHub org people page, e.g. github.com/orgs/brave/people
  2. Click on a Tip button next to any of the members

Expected result:
The tipping banner (or join rewards panel if haven't joined) shows up

Actual result:
Nothing happens.

Reproducible in 1.43.x, 1.44.x, 1.45.x

@mkarolin mkarolin self-assigned this Sep 21, 2022
@stephendonner stephendonner changed the title Tip button on Github org people page doesn't work Tip button on GitHub org people page doesn't work Sep 21, 2022
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Sep 21, 2022
@mkarolin mkarolin added this to the Greaselion Next milestone Sep 21, 2022
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 22, 2022

Verified using dev component for:

Brave Local Data Updater - Version: 1.0.649

Launched 1.44.95 using --use-dev-goupdater-url and ensured issue is fixed with the component 1.0.649, the Tip button is aligned correctly in https://github.com/orgs/brave/people and click on Send a tip button opens up the tipping banner

Example Example
image image

Spot checked following github pages and ensured inline tip is aligned correctly and click on Send a tip button opens up the tipping banner for the user to send a tip

https://github.com/brave/brave-browser/commits/master?after=05749476419ca759df8d5f7873bec79f58d2f624+69&branch=master&qualified_name=refs%2Fheads%2Fmaster
brave/brave-core#8852
#15005
https://github.com/emerick?tab=stars
https://gist.github.com/darkdh/85fed2542190510aaee0f3ad91091818

@stephendonner
Copy link

Verified PASSED using

Brave 1.43.93 Chromium: 105.0.5195.127 (Official Build) (x86_64)
Revision 912488396852bf658ab32465980c0b93a3c27a83-refs/branch-heads/5195@{#1109}
OS macOS Version 11.7 (Build 20G817)

Launched 1.43.93 using --use-dev-goupdater-url and ensured issue is fixed with the component 1.0.649, the Tip button is aligned correctly in https://github.com/orgs/brave/people and click on Send a tip button opens up the tipping banner

example example
Screen Shot 2022-09-22 at 8 55 22 AM Screen Shot 2022-09-22 at 8 55 27 AM

Spot checked following github pages and ensured inline tip is aligned correctly and click on Send a tip button opens up the tipping banner for the user to send a tip:

https://github.com/brave/brave-browser/commits/master?after=05749476419ca759df8d5f7873bec79f58d2f624+69&branch=master&qualified_name=refs%2Fheads%2Fmaster

example example
Screen Shot 2022-09-22 at 8 53 52 AM Screen Shot 2022-09-22 at 8 53 55 AM

@mkarolin
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants