Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Add checked accounts until user selects an account in Import from hardware wallet screen #25617

Closed
srirambv opened this issue Sep 26, 2022 · 2 comments · Fixed by brave/brave-core#15224
Closed

Disable Add checked accounts until user selects an account in Import from hardware wallet screen #25617

srirambv opened this issue Sep 26, 2022 · 2 comments · Fixed by brave/brave-core#15224
Assignees
@Douglashdaniel
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop polish Nice to have — usually related to front-end/visual tasks QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.45.x - Release

Comments

@srirambv
Copy link
Contributor

Description

Disable Add checked accounts until user selects an account in Import from hardware wallet screen

Steps to Reproduce

  1. Connect Ledger
  2. Initiate import from Ledger account
  3. Add checked accounts button is enabled by default even without selecting any checkbox to import account

Actual result:

Add checked accounts button is enabled by default even without selecting any checkbox to import account

Expected result:

Enable button only when user selects an account to import

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.44.99 Chromium: 106.0.5249.55 (Official Build) (64-bit)
Revision 4d5f098fca6ab7f4b6b7c240be3d9593c2357709-refs/branch-heads/5249@{#531}
OS All

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @nvonpentz @Douglashdaniel @onyb
@srirambv srirambv added polish Nice to have — usually related to front-end/visual tasks QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels Sep 26, 2022
@srirambv srirambv mentioned this issue Sep 26, 2022
Closed
@Douglashdaniel Douglashdaniel self-assigned this Sep 26, 2022
@Douglashdaniel Douglashdaniel added the front-end-change This task is a front end task and doesn't need any C++ changes label Sep 26, 2022
@Douglashdaniel Douglashdaniel mentioned this issue Sep 26, 2022
Merged
25 tasks
@kjozwiak kjozwiak added this to the 1.45.x - Beta milestone Sep 29, 2022
@kjozwiak
Copy link
Member

The above requires 1.45.79 or higher for 1.45.x verification 👍

@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.45.104 Chromium: 106.0.5249.126 (Official Build) beta (64-bit)
Revision fb2e06d2dee20fe0c804528502b5ad72c613abd9-refs/branch-heads/5249_118@{#3}
OS Linux
  • Verified steps from issue description & brave/brave-core#15224
  • Verified Add checked account button enables only when an account is selected
Account unselected Account selected
image image

Verification passed on

Brave 1.45.104 Chromium: 106.0.5249.126 (Official Build) beta (64-bit)
Revision fb2e06d2dee20fe0c804528502b5ad72c613abd9-refs/branch-heads/5249_118@{#3}
OS Windows 11 Version 22H2 (Build 22621.674)
  • Verified steps from issue description & brave/brave-core#15224
  • Verified Add checked account button enables only when an account is selected
Account unselected Account selected
image image

Verification passed on

Brave 1.45.104 Chromium: 106.0.5249.126 (Official Build) beta (arm64)
Revision fb2e06d2dee20fe0c804528502b5ad72c613abd9-refs/branch-heads/5249_118@{#3}
OS macOS Version 12.4 (Build 21F79)
  • Verified steps from issue description & brave/brave-core#15224
  • Verified Add checked account button enables only when an account is selected
Account unselected Account selected
image image

@LaurenWags LaurenWags mentioned this issue Oct 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop polish Nice to have — usually related to front-end/visual tasks QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.45.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): Disable Add Hardware Accounts Button Until Checked brave/brave-core
3 participants
@kjozwiak @srirambv @Douglashdaniel