Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy Clean URL on links in page #25625

Closed
bsclifton opened this issue Sep 26, 2022 · 2 comments
Closed

Copy Clean URL on links in page #25625

bsclifton opened this issue Sep 26, 2022 · 2 comments
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. closed/works-for-me OS/Desktop priority/P4 Planned work. We expect to get to it "soon".

Comments

@bsclifton
Copy link
Member

bsclifton commented Sep 26, 2022

Description

Follow up to #23315

For employees wanting to see the spec (by @fmarier), go on GDrive and search for Copy clean URL

For the MVP of the original feature, it only shows in two places.

  1. Share widget
    image
  2. Right clicking omnibox (url bar)
    image

This functionality should also be on in-page links (when you right click). For example, here:
image

From the spec:

We could have a Copy clean link address option there too, but it requires more work since in that case we’ll have to first apply our normal URL modification rules (e.g. debouncing, query filter, de-AMP, HTTPS Everywhere) before applying the clean URL filter.

In order to ship the feature faster, this context menu will not be part of the MVP and will be addressed in a follow-up later.

@snowbound
Copy link

Just a FYI had an issue with this feature in Brave Beta as outline in my post on Brave subreddit

@rebron
Copy link
Collaborator

rebron commented Sep 15, 2023

Screenshot 2023-09-15 at 11 56 02 AM

Closing, not sure when we added it to content menu though.

cc: @spylogsster

@rebron rebron closed this as completed Sep 15, 2023
@rebron rebron added closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. closed/works-for-me and removed QA/Yes release-notes/include feature-request labels Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. closed/works-for-me OS/Desktop priority/P4 Planned work. We expect to get to it "soon".
Projects
None yet
Development

No branches or pull requests

3 participants