Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict, may break sites option is selected by default in Block fingerprinting settings dropdown in brave://settings/shields #26068

Closed
GeetaSarvadnya opened this issue Oct 17, 2022 · 4 comments · Fixed by brave/brave-core#15482

Comments

@GeetaSarvadnya
Copy link

Description

Strict, may break sites option selected by default in Block fingerprinting settings dropdown in brave://settings/shields

Steps to Reproduce

  1. Clean profile 1.46.63
  2. Open brave://settings/shields
  3. Look for Block fingerprinting setting
  4. Strict, may break sites selected by default

Actual result:

Strict, may break sites selected by default in Block fingerprinting setting in brave://settings/shields
image

Expected result:

Standard should be selected by default

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.46.63 Chromium: 107.0.5304.36 (Official Build) nightly (64-bit)
Revision 2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS Windows 10 Version 21H2 (Build 19044.2130)
## Version/Channel Information:
  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @emerick @rebron @brave/qa-team

@GeetaSarvadnya GeetaSarvadnya added bug feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields QA/Yes QA/Test-Plan-Specified regression OS/Desktop labels Oct 17, 2022
@emerick
Copy link
Contributor

emerick commented Oct 17, 2022

I think this is possibly due to brave/brave-core#14893. At least, I don't see where refreshState is called nor any definition for getHTTPSEverywhereEnabled.

@stephendonner
Copy link

Verified PASSED using

Brave 1.46.68 Chromium: 107.0.5304.36 (Official Build) nightly (x86_64)
Revision 2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS macOS Version 13.0 (Build 22A379)

Steps:

  1. installed 1.46.68
  2. launched Brave
  3. opened brave://settings/shields
  4. examined the default setting for Block fingerprinting

Confirmed the default is now properly Standard

Screenshot 2022-10-18 at 5 15 51 PM

@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.46.69 Chromium: 107.0.5304.36 (Official Build) beta (64-bit)
-- | --
Revision | 2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS | Windows 11 Version 22H2 (Build 22621.674)

Steps:

  1. installed 1.46.69
  2. launched Brave
  3. opened brave://settings/shields
  4. examined the default setting for Block fingerprinting

Confirmed the default is now properly Standard

image

@LaurenWags
Copy link
Member

Verified passed with

Brave	1.46.106 Chromium: 107.0.5304.110 (Official Build) beta (64-bit) 
Revision	2a558545ab7e6fb8177002bf44d4fc1717cb2998-refs/branch-heads/5304@{#1202}
OS	Linux

Steps:

  1. installed 1.46.106
  2. launched Brave
  3. opened brave://settings/shields
  4. examined the default setting for Block fingerprinting

Confirmed the default is now properly Standard

Screen Shot 2022-11-11 at 9 50 25 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants