Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update text to Copy clean link #26106

Closed
rebron opened this issue Oct 18, 2022 · 2 comments · Fixed by brave/brave-core#15518
Closed

update text to Copy clean link #26106

rebron opened this issue Oct 18, 2022 · 2 comments · Fixed by brave/brave-core#15518
Assignees
Labels
needs-text-change This change requires some careful wording. OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/exclude

Comments

@rebron
Copy link
Collaborator

rebron commented Oct 18, 2022

Description

For the Copy clean URL feature, update the text and simplify to Copy clean link in the Share menu and in the right click context menus from the URL bar and on a link on a page.

Steps to Reproduce

  1. Right click on a link on page.
  2. Go to URL bar and right click on the URL.
  3. Go to Share menu icon in the URL bar.

Actual result:

Text label below Copy reads as `Copy clean link (only main URL)

Share menu
Screenshot 2022-10-18 at 12 53 53 PM
Context menu URL bar
Screenshot 2022-10-18 at 12 54 03 PM

Expected result:

Label should read as Copy clean link

Share menu
196314358-629cf960-914f-43cb-a769-fb469f2c2268

Context menu URL bar
196323051-1f17a492-9b76-42a3-bd71-973e08251a9d

Reproduces how often:

Easily.

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

Related issues:

#23315 initial issue
#25845 context menu follow-up
#25621 discussion of text

cc: @fmarier, @mkarolin @spylogsster @rmcfadden3

@kjozwiak
Copy link
Member

The above requires 1.45.111 or higher for 1.45.x verification 👍

@MadhaviSeelam
Copy link

MadhaviSeelam commented Oct 24, 2022

Verification PASSED using

Brave | 1.45.111 Chromium: 107.0.5304.62 (Official Build) (64-bit)
-- | --
Revision | 1eec40d3a5764881c92085aaee66d25075c159aa-refs/branch-heads/5304@{#942}
OS | Windows 11 Version 21H2 (Build 22000.1098)
  • Install 1.45.111
  • launch Brave
  • visit a website (github.com)
  • Go to URL bar and right click on the URL.

Confirmed the label in the URL bar context menu reads Copy clean link

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-text-change This change requires some careful wording. OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants