Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Update search engine defaults for BR / AR #26318

Closed
timchilds opened this issue Oct 27, 2022 · 3 comments · Fixed by brave/brave-core#15783
Closed

[Android] Update search engine defaults for BR / AR #26318

timchilds opened this issue Oct 27, 2022 · 3 comments · Fixed by brave/brave-core#15783

Comments

@timchilds
Copy link

timchilds commented Oct 27, 2022

Description

Update search engine defaults for:

  • Brazil (BR)
  • Argentina (AR)

Brave should be at the top of drop down list at settings -> search engines.

Related: #18331, #23814 and #26181

Test plan

Region set to BR / AR

  1. Fresh profile
  2. Search onboarding should NOT be shown
  3. Default search engine SHOULD be Brave
  4. Visit settings -> search engines
  5. Brave SHOULD be first in the Default search engines list

Region set to anything else (excluding CA / DE / FR / GB / US / AT / ES / MX)

  1. Fresh profile
  2. Search onboarding SHOULD be shown
  3. Default will NOT be Brave Search
  4. Visit settings -> search engines
  5. Brave SHOULD be first in the Default search engines list - unless you're in a region where Yandex is default (AM, AZ, BY, KG, KZ, MD, RU, TJ, TM, UZ). In that case it will be second.

Notes for test plan

#23814 (comment)

@kjozwiak
Copy link
Member

kjozwiak commented Nov 2, 2022

As per #26181 (comment), we basically need to change the onboarding behaviour for BR & AR. Believe we remove the onboarding when the user taps on the URL. We're currently displaying it.

@kjozwiak
Copy link
Member

kjozwiak commented Nov 4, 2022

The above requires 1.45.121 or higher for 1.45.x verification 👍

@Uni-verse
Copy link
Contributor

Uni-verse commented Nov 14, 2022

Verified on Samsung Galaxy S21 & Samsung Galaxy Tab S7 using the following build(s):

Brave	1.45.125 Chromium: 107.0.5304.110 (Official Build) (64-bit) 
Revision	2a558545ab7e6fb8177002bf44d4fc1717cb2998-refs/branch-heads/5304@{#1202}
OS	Android 12; Build/SP1A.210812.016

Test Plan: brave/brave-core#15783 (comment)

AR (Argentina) locale (New addition)

  • Ensured Brave is default SE for normal tabs
  • Ensured Brave is default SE for private tabs
  • Ensured SE onboarding is removed
Example Example Example Example
screenshot-1668459359581 screenshot-1668459365027 screenshot-1668459370779 screenshot-1668459446696

BR (Brazil) locale (New addition)

  • Ensured Brave is default SE for normal tabs
  • Ensured Brave is default SE for private tabs
  • Ensured SE onboarding is removed
Example Example Example Example
screenshot-1668456775792 screenshot-1668456782056 screenshot-1668456788398 screenshot-1668457555714

DE (Germany) Existing Brave Default SE

  • Ensured Brave is default SE for normal tabs
  • Ensured Brave is default SE for private tabs
  • Ensured SE onboarding is removed
Example Example Example
screenshot-1668458813256 screenshot-1668458821998 screenshot-1668458828325

CO (Columbia) Existing Non-Brave Default SE

  • Ensured default SE for normal tabs is set as Google
  • Ensured default SE for private tabs is set as Google
  • Ensured tapping on the URL on the second attempt displays the SE onboarding modal without issues
  • Ensured Google is selected as the default SE via the onboarding modal
  • Ensured Normal & Private SE are updated correctly if another SE is selected from the onboarding modal
Example Example Example Example Example
screenshot-1668460455749 screenshot-1668460462071 screenshot-1668460474994 screenshot-1668460513704 screenshot-1668463291547

Yandex Default SE (RU) Locale

  • Ensured Default SE is set to Yandex for normal and private tabs
  • Ensured SE Onboarding is displayed
  • Ensured that SE settings are updated accordingly after selecting SE from onboarding modal
Example Example Example Example
screenshot-1668461159901 screenshot-1668461170635 screenshot-1668461177138 screenshot-1668461190889
screenshot-1668462636510 screenshot-1668462674610 screenshot-1668462680041 screenshot-1668462686980

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment