Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-followed sources should reflect Followed status in the Customize dialog #26324

Closed
stephendonner opened this issue Oct 27, 2022 · 4 comments · Fixed by brave/brave-core#15963

Comments

@stephendonner
Copy link

stephendonner commented Oct 27, 2022

Description

Pre-followed sources should reflect Followed status in the Customize dialog

Steps to Reproduce

  1. install 1.47.21
  2. launch Brave
  3. set brave://flags/#brave-news-v2 to Enabled
  4. set brave://flags/#brave-news-subscribe-button to Enabled
  5. click Relaunch
  6. load theatlantic.com
  7. click on the Manage Subscriptions icon in the URL bar
  8. notice that The Atlantic feed is followed
  9. click Manage Feeds >
  10. look for The Atlantic

Actual result:

URL bar Customize dialog
Screen Shot 2022-10-27 at 12 52 16 PM Screen Shot 2022-10-27 at 12 52 32 PM

Expected result:

The Atlantic should should as already being followed

Screen Shot 2022-10-27 at 1 04 26 PM

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.47.21 Chromium: 107.0.5304.68 (Official Build) nightly (x86_64)
Revision a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS macOS Version 11.7.1 (Build 20G918)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @aguscruiz @mattmcalister @fallaciousreasoning @petemill

@stephendonner stephendonner changed the title Pre-followed sources should reflect Followed status in the `Customize ccccccvvlfcttvlhbdcehkrhthjrhtvunkrdgjjvnkcb Pre-followed sources should reflect Followed status in the Customize dialog Oct 27, 2022
@petemill
Copy link
Member

This is related to #26631 and adds an extra layer about follows being added from completely outside the current NTP instance and further underlining the need to have an event get fired.

@fallaciousreasoning
Copy link

So I think this is actually separate to #26631 - this is an issue with the migration from V1 to V2, The Atlantic was default enabled in V1 and the subscribe dialog reflects that default enabled status.

@LaurenWags
Copy link
Member

Requires 1.46.122 or higher to test.

@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.46.122 Chromium: 108.0.5359.48 (Official Build) beta (x86_64)
Revision 18ceeca0d99318e70c00d2e04d88aa55488b5c63-refs/branch-heads/5359@{#854}
OS macOS Version 11.7.1 (Build 20G918)

Steps:

  1. installed 1.46.122
  2. launched Brave
  3. opened brave://flags
  4. set brave://flags/#brave-news-subscribe-button to Enabled
  5. clicked Relaunch
  6. opened a new-tab page
  7. clicked on Customize
  8. clicked on Brave News
  9. clicked on Turn on Brave News
  10. confirmed I was default following Top Sources, in the Following column
  11. loaded theatlantic.com
  12. clicked on the Manage Subscriptions button
  13. examined the The Atlantic and Best of the Atlantic feeds statuses

Confirmed neither The Atlantic nor Best of the Atlantic were Followed/shown as Followed

example example example
Screen Shot 2022-11-21 at 10 56 57 PM Screen Shot 2022-11-21 at 10 55 49 PM Screen Shot 2022-11-21 at 10 55 58 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment