Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default auto lock setting from 5 minutes to 10 minutes #26362

Closed
bbondy opened this issue Oct 28, 2022 · 4 comments · Fixed by brave/brave-core#18544
Closed

Change default auto lock setting from 5 minutes to 10 minutes #26362

bbondy opened this issue Oct 28, 2022 · 4 comments · Fixed by brave/brave-core#18544
Assignees
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include

Comments

@bbondy
Copy link
Member

bbondy commented Oct 28, 2022

Many people have complained that we re-lock the wallet too quickly. Let's update from a default of 5 minutes auto-lock to a default of 10 minutes. Thread here: https://bravesoftware.slack.com/archives/C8MP8ME4C/p1666893856182529

@bbondy bbondy added OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality labels Oct 28, 2022
@bbondy bbondy added this to Web3 Oct 28, 2022
@bbondy bbondy added the priority/P2 A bad problem. We might uplift this to the next planned release. label Oct 28, 2022
@bbondy bbondy moved this to Backlog in Web3 Oct 28, 2022
@stephendonner stephendonner changed the title Change default auto lock setting from 5minutes to 10 minutes Change default auto lock setting from 5 minutes to 10 minutes Oct 28, 2022
@vadimstruts
Copy link
Collaborator

Hi @bbondy
Should we change default value only for new users or for new and all existing, who have the default value used (i.e. apply special preferences migration)?

@bbondy
Copy link
Member Author

bbondy commented May 19, 2023

I think let's do the change, but please include someone from the security team on the review of the pull request.

It should just be a default value change, no migration.

@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 13 running 1.53.94 x64 Beta build

  • Verified steps from issue description
  • Verified new installs have a 10 mins timeout set as default
  • Verified upgrading from an older install with a custom timeout set is retained
  • Encountered #31077
26362.mp4

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.53.94 Chromium: 114.0.5735.133 (Official Build) beta (64-bit)
Revision fbfa2ce68d01b2201d8c667c2e73f648a61c4f4a-refs/branch-heads/5735@{#1270}
OS Windows 11 Version 22H2 (Build 22621.1848)
  • Verified steps from issue description
  • Verified new installs have a 10 mins timeout set as default
  • Verified upgrading from an older install with a custom timeout set is retained
  • Verified upgrading from an older install without changing timeout setting is updated to 10 mins as default
Clean install Upgrade without timeout change Upgrade with timeout change
26362.-.Clean.install.mp4
26362.-.Upgrade.with.no.change.mp4
26362.-.Upgrade.with.change.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants