-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Brave News]: Update Subscribe Button Icon #26997
Comments
Hey @martin-c0des, I've just been updating the icon and there isn't heaps to distinguish between the subscribed & unsubscribed states: |
We'll be uplifted the above into the |
The above requires |
Verification PASSED on
Steps:
Dark modeLight mode |
Verified
|
Brave | 1.46.141 Chromium: 108.0.5359.99 (Official Build) (x86_64) |
---|---|
Revision | 410951fc34bb4b2cbf182231f9f779efaafaf682-refs/branch-heads/5359_71@{#9} |
OS | macOS Version 13.1 (Build 22C65) |
Steps:
- installed
1.46.141
- launched Brave
- opened
brave://flags
- set
brave://flags/#brave-news-subscribe-button
toEnabled
- clicked
Relaunch
- loaded
planet.mozilla.org
- verified subscribed/unsubscribed/hover states
Light
mode
unsubscribed | unsubscribed, hover | subscribed | subscribed, hover |
---|---|---|---|
Dark
mode
unsubscribed | unsubscribed, hover | subscribed | subscribed, hover |
---|---|---|---|
We have a new subscribe button icon we should use thanks to @martin-c0des.
https://www.figma.com/file/w13WS9lovJubjbSjtK1fVo/Brave-Desktop---Add-to-Brave-News?node-id=129%3A13678&t=R4BQ7wBZ9LhXjZnj-0#313822908
The text was updated successfully, but these errors were encountered: