Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Brave News]: Update Subscribe Button Icon #26997

Closed
fallaciousreasoning opened this issue Nov 27, 2022 · 7 comments · Fixed by brave/brave-core#16096
Closed

[Brave News]: Update Subscribe Button Icon #26997

fallaciousreasoning opened this issue Nov 27, 2022 · 7 comments · Fixed by brave/brave-core#16096

Comments

@fallaciousreasoning
Copy link

fallaciousreasoning commented Nov 27, 2022

We have a new subscribe button icon we should use thanks to @martin-c0des.

image
https://www.figma.com/file/w13WS9lovJubjbSjtK1fVo/Brave-Desktop---Add-to-Brave-News?node-id=129%3A13678&t=R4BQ7wBZ9LhXjZnj-0#313822908

@fallaciousreasoning
Copy link
Author

Hey @martin-c0des, I've just been updating the icon and there isn't heaps to distinguish between the subscribed & unsubscribed states:

Unsubscribed
image

Subscribed
image

@fallaciousreasoning
Copy link
Author

I had a dig into the code, and it looks like we were doing something to reduce the contrast, to make the colors the same as the other icons. Even with that disabled it's kinda hard to tell the icon has changed:

No contrast reduction:
image

@kjozwiak
Copy link
Member

We'll be uplifted the above into the 1.46.x maintenance release via brave/brave-core#16143 once the initial 1.46.x build goes out. Verification will be completed on 1.46.x.

@kjozwiak
Copy link
Member

kjozwiak commented Dec 7, 2022

The above requires 1.46.139 or higher for 1.46.x verification 👍

@GeetaSarvadnya
Copy link

Verification PASSED on

Brave | 1.46.141 Chromium: 108.0.5359.99 (Official Build) (64-bit)
-- | --
Revision | 410951fc34bb4b2cbf182231f9f779efaafaf682-refs/branch-heads/5359_71@{#9}
OS | Windows 10 Version 21H2 (Build 19044.2251)

Steps:

  1. installed 1.48.13
  2. launched Brave
  3. set brave://flags/#brave-news-subscribe-button to Enabled
  4. clicked Relaunch
  5. loaded planet.mozilla.org
  6. changed modes and theme
  7. hovered over the buttons

Confirmed new RSS icon across the following:

Dark mode Dark mode, hover Light mode Light mode, hover purple theme purple theme, hover
image image image image image image

@btlechowski
Copy link

btlechowski commented Dec 9, 2022

Verification PASSED on

Brave 1.46.141 Chromium: 108.0.5359.99 (Official Build) (64-bit)
Revision 410951fc34bb4b2cbf182231f9f779efaafaf682-refs/branch-heads/5359_71@{#9}
OS Ubuntu 18.04 LTS

Steps:

  1. installed 1.46.x
  2. launched Brave
  3. set brave://flags/#brave-news-subscribe-button to Enabled
  4. clicked Relaunch
  5. loaded planet.mozilla.org
  6. changed modes and theme
  7. verified subscribed/unsubscribed/hover states

Dark mode

unsubscribed
image

unsubscribed - hover
image

subscribed
image

subscribed - hover
image

Light mode

unsubscribed
image

unsubscribed - hover
image

subscribed
image

subscribed - hover
image

@stephendonner
Copy link

Verified PASSED using

Brave 1.46.141 Chromium: 108.0.5359.99 (Official Build) (x86_64)
Revision 410951fc34bb4b2cbf182231f9f779efaafaf682-refs/branch-heads/5359_71@{#9}
OS macOS Version 13.1 (Build 22C65)

Steps:

  1. installed 1.46.141
  2. launched Brave
  3. opened brave://flags
  4. set brave://flags/#brave-news-subscribe-button to Enabled
  5. clicked Relaunch
  6. loaded planet.mozilla.org
  7. verified subscribed/unsubscribed/hover states

Light mode

unsubscribed unsubscribed, hover subscribed subscribed, hover
Screenshot 2022-12-09 at 10 34 02 AM Screenshot 2022-12-09 at 10 34 07 AM Screenshot 2022-12-09 at 10 48 24 AM Screenshot 2022-12-09 at 10 55 35 AM

Dark mode

unsubscribed unsubscribed, hover subscribed subscribed, hover
Screenshot 2022-12-09 at 10 34 32 AM Screenshot 2022-12-09 at 10 34 36 AM Screenshot 2022-12-09 at 10 56 57 AM Screenshot 2022-12-09 at 10 56 51 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment