Upgrade from Chromium 109 to Chromium 110 #27221

emerick · 2022-12-07T18:42:32Z

Upgrade from Chromium 109 to Chromium 110

https://chromium.googlesource.com/chromium/src/+log/109.0.5414.80..110.0.5481.40/?pretty=fuller&n=10000

QA tests:
This is a major Chromium version bump, please do full passes.

Desktop Affected areas:

brave://settings
Brave Wallet, both the page and panel interfaces
Cookie-related settings
Brave Sync
Brave Search
Side panel
Multiple profiles

iOS Affected areas:

Nothing user-facing of note

Android Affected areas:

NTP layout (particularly with Google as default search engine)
Auto-play setting (double check it works)
VPN (double check you can buy a subscription, check with Deep on how to do it)
Sync (double check it generally works)

MadhaviSeelam · 2023-01-26T19:55:48Z

Verification PASSED using

Brave | 1.49.64 Chromium: 110.0.5481.52 (Official Build) nightly (64-bit)
-- | --
Revision | 979113183ded4544a2c443aceb1629c430907e52-refs/branch-heads/5481@{#636}
OS | Windows 11 Version 21H2 (Build 22000.1455)

And

Brave | 1.49.75 Chromium: 110.0.5481.52 (Official Build) nightly (64-bit)
-- | --
Revision | 979113183ded4544a2c443aceb1629c430907e52-refs/branch-heads/5481@{#636}
OS | Windows 11 Version 21H2 (Build 22000.1455)

brave://settings - `PASSED`

brave://settings

- Wallet is renamed to Web3 - IPFS is moved to `brave://settings/web3`

1.49.64 Chromium: 110.0.5481.52	1.47.186 Chromium: 109.0.5414.119

brave://settings/clearBrowserData

Verified Basic, Advanced and On exit options

example	example

brave://settings/appearance

Suggested sites options is removed from Show autocomplete suggestions in address bar
Sidebar/Sidepanel options are located together

1.49.64 Chromium: 110.0.5481.52	1.47.186 Chromium: 109.0.5414.119

brave://settings/web3

Following options are moved from brave://settings/extensions
- Resolve Unstoppable Domains domain names
- Resolve Ethereum Name Service (ENS) domain names

1.49.64 Chromium: 110.0.5481.52	1.47.186 Chromium: 109.0.5414.119

brave://settings/privacy

brave://settings/shields

Brave Wallet, both the page and panel interfaces - `PASSED`

Verified by @srirambv via Brave Wallet tests for 1.49.x - Nightly (Checking C110) #28038

Cookie-related settings - `PASSED`

New setting Block third-party cookies in Private displayed in brave://settings/cookies

1.49.64 Chromium: 110.0.5481.52	1.47.186 Chromium: 109.0.5414.119

Cookie settings:

confirmed that cookie settings are retained in an upgraded profile
confirmed cookies settings are working as expected in the brave://settings/cookies
confirmed local and global cookies shield settings are working as expected

Verification as follows:

opened cnn.com and confirmed default setting of Block cross-site cookies shown in the Shields panel
Opened brave://settings/cookies and confirmed default setting of Block third-party cookies shown
opened brave://settings/shileds and confirmed default settings of Only cross-site shown
changed the setting to Block all cookies in brave://settings/cookies
reloaded cnn.com and confirmed Block all cookies are shown in the Shields panel as expected
opened brave://settings/shields and confirmed Block cookies: All` shown as expected
Opened brave://settings/cookies and select Allow all cookies
reloaded cnn.com and confirmed that Allow all cookies setting shown in the Shields panel as expected
opened brave://settings/shileds and confirmed the Disabled shown as expected
opened brave://settings/cookies and switch to Block third-party cookies
reloaded cnn.com and confirmed Block cross-site cookies setting
switched to Allow all cookies in the shields panel for cnn.com site
confirmed cnn.com is added to Sites that can always use cookies in brave://settings/cookies
confirmed brave://settings/cookiesis still shownBlock third-party cookies` setting
deleted www.cnn.com entry from Sites that can always use cookies in brave://settings/cookies
reloaded cnn.com and confirmed the setting was reverted to Block cross-site cookies in the shields panel
change to Block all cookies in the shields panel for cnn.com
returned to brave://settings/cookies and confirmed www.cnn.com entry is displayed in Sites that can never use cookies

example	example	example	example	example

Brave Sync - `PASSED`

Covered the testing in Manual test run on Win x64 for 1.49.x - Nightly (Checking C110) #28066
Additionally verified new Delete Sync Account functionality

Brave Search - `PASSED`

confirmed WDP infobar shown when Brave is a default search engine and Web Discovery Project toggle is enabled
confirmed links opened without issues on Search results page
verified keyword search, URL-precedence and working as expected
verified bookmark icon displayed in the omnibox autocomplete entry as expected

ex	ex	ex	ex	ex	ex

Side panel - `PASSED`

Confirmed that sidebar is shown left by default in the nightly channel
Confirmed sidepanel opens when clicked on sidebar icon (i.e. Reading list and Bookmarks)
Confirmed the side panel can be opened/closed when toolbar button is toggled on/off
Confirmed reading list panel or bookmarks panel opened when clicked toolbar button (whichever was the last open)
Confirmed when side panel opened, relevant sidebar icon (reading list or bookmarks) was selected
Confirmed the toolbar button shown as selected with highlighted gray background
Confirmed sidepanel can be opened/closed when bookmarks or reading list icons toggled on/off
Confirmed that user can add the list of websites to the reading list by clicking on the +Add current tab in the panel
Confirmed bookmarks are shown in the sidepanel
Confirmed that sidepanel is shown in all the window types (Normal, PT, TOR)
Confirmed if the sidebar is left aligned and the toolbutton is shown accordingly
Confirmed if sidebar settings are changed to show on the right, sidepanel is shown on the right and toolbar is shown accordingly
Confirmed vertical tabs working as expected after fix in 1.49.75

Example	Example	Example

Multiple profiles - `PASSED`

Confirmed that user can create the multiple profiles (e.g Profile 1 and Profile 2)
open brave://settings and import bookmarks and add extensions in Profile 1
Ensured that changes made in settings in Profile 1are NOT reflected in Profile 2
Ensured that the bookmarks and extensions are NOT reflected in Profile 2
Ensured that updated rewards settings are specific to Profile 1 and are not reflected in Profile 2
Confirmed able to edit and delete profiles from Manage profiles

Brave startup calls - `PASSED`

Confirmed that only brave domains are listed in the Charles when the nightly build is launched with a clean profile
Confirmed no calls to google, gstatic, etc domains when the nightly build is launched with a clean profile

Uni-verse · 2023-01-30T20:34:37Z

Verified on Samsung Galaxy S21 5G using version(s):

Brave	1.49.64 Chromium: 110.0.5481.52 (Official Build) canary (64-bit) 
Revision	979113183ded4544a2c443aceb1629c430907e52-refs/branch-heads/5481@{#636}
OS	Android 13; Build/TP1A.220624.014

NTP Layout

Verified NTP layout on fresh profile
Verified NTP layout with background SI disabled
Verified NTP layout with feeds news enabled
Verified top sites will be displayed with 2 rows when background images are disabled in New Tab settings
Encountered: Google search banner displayed on NTP when default SE is set to Google [CR110] #28145

Example	Example	#28145

Autoplay site setting

Verified videos are not played automatically when autoplay is disabled in site settings
Verified videos will autoplay when autoplay is enabled in site settings

Autoplay OFF	Autoplay ON
autoplay_1.mp4	autoplay_On.mp4

VPN

Verified enabled VPN on fresh profile

Example	Example	Example	Example

Sync

Verified creating Sync chain using fresh profile
Verified connecting to sync chain using code words
Verified connecting to sync chain by scanning QR code

Example	Example	Example	Example

GeetaSarvadnya · 2023-01-31T14:13:36Z

@MadhaviSeelam We usually ask @srirambv to run the web3 related affected areas as he is the web3 QA Spoc and he knows in and out of WEB3 and if we test this there are chances we may miss some testing around web3. Lets @srirambv test this and give a sign off

@srirambv Could you please run Brave Wallet, both the page and panel interfaces on Desktop. Thanks!

srirambv · 2023-01-31T14:26:35Z

We should be good with Brave Wallet, both the page and panel interfaces as I already ran through the Wallet Manual pass here on the PR #28038

kjozwiak · 2023-02-01T18:54:52Z

The above requires 1.48.153 or higher for 1.48.x verification 👍

emerick added QA/Yes release-notes/include QA/Test-Plan-Specified OS/Android Fixes related to Android browser functionality Chromium/upgrade major Major version bump. (ex: Chromium 88 to 89) OS/Desktop labels Dec 7, 2022

emerick assigned emerick, cdesouza-chromium and samartnik Dec 7, 2022

emerick mentioned this issue Dec 11, 2022

Upgrade from Chromium 109 to Chromium 110 brave/brave-core#16324

Merged

25 tasks

DJAndries mentioned this issue Jan 23, 2023

Replace GetPrimaryUserProfile desktop calls with GetLastUsedProfile in ads stats updater helper brave/brave-core#16815

Merged

25 tasks

emerick closed this as completed in brave/brave-core#16324 Jan 26, 2023

emerick added this to the 1.49.x - Nightly milestone Jan 26, 2023

MadhaviSeelam added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jan 26, 2023

emerick mentioned this issue Jan 27, 2023

Upgrade from Chromium 109 to Chromium 110 (1.48.x) brave/brave-core#16884

Merged

This was referenced Jan 27, 2023

Brave crashed when clicked Wallet icon on the sidebar in the Guest window #28107

Open

[C110] More Info link on Help improve Brave Search... info bar doesn't work #28139

Closed

[CR110] Onboarding is not completed #28110

Closed

Uni-verse added the QA Pass - Android ARM label Jan 30, 2023

Uni-verse mentioned this issue Jan 30, 2023

Manual test run on ARM Tablet for 1.49.x - Nightly (Checking C110) #28068

Closed

1 task

MadhaviSeelam added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jan 31, 2023

brave-builds modified the milestones: 1.49.x - Nightly, 1.48.x - Beta Feb 1, 2023

LaurenWags added the QA/Test-All-Platforms label Feb 2, 2023

kjozwiak added QA/No release-notes/exclude and removed QA/Yes release-notes/include labels Feb 2, 2023

kjozwiak mentioned this issue Feb 2, 2023

Upgrade from Chromium 110.0.5481.52 to Chromium 110.0.5481.77 #28219

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade from Chromium 109 to Chromium 110 #27221

Upgrade from Chromium 109 to Chromium 110 #27221

emerick commented Dec 7, 2022 •

edited

Loading

MadhaviSeelam commented Jan 26, 2023 •

edited

Loading

Uni-verse commented Jan 30, 2023 •

edited

Loading

GeetaSarvadnya commented Jan 31, 2023

srirambv commented Jan 31, 2023

kjozwiak commented Feb 1, 2023

Upgrade from Chromium 109 to Chromium 110 #27221

Upgrade from Chromium 109 to Chromium 110 #27221

Comments

emerick commented Dec 7, 2022 • edited Loading

MadhaviSeelam commented Jan 26, 2023 • edited Loading

brave://settings - PASSED

Brave Wallet, both the page and panel interfaces - PASSED

Cookie-related settings - PASSED

Brave Sync - PASSED

Brave Search - PASSED

Side panel - PASSED

Multiple profiles - PASSED

Brave startup calls - PASSED

Uni-verse commented Jan 30, 2023 • edited Loading

GeetaSarvadnya commented Jan 31, 2023

srirambv commented Jan 31, 2023

kjozwiak commented Feb 1, 2023

emerick commented Dec 7, 2022 •

edited

Loading

MadhaviSeelam commented Jan 26, 2023 •

edited

Loading

brave://settings - `PASSED`

Brave Wallet, both the page and panel interfaces - `PASSED`

Cookie-related settings - `PASSED`

Brave Sync - `PASSED`

Brave Search - `PASSED`

Side panel - `PASSED`

Multiple profiles - `PASSED`

Brave startup calls - `PASSED`

Uni-verse commented Jan 30, 2023 •

edited

Loading