Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing new tab background image options. #27309

Closed
TheJanox824 opened this issue Dec 12, 2022 · 7 comments
Closed

Missing new tab background image options. #27309

TheJanox824 opened this issue Dec 12, 2022 · 7 comments
Assignees
Labels
closed/duplicate Issue has already been reported feature/new-tab feature/settings needs-investigation A bug not 100% confirmed/fixed OS/Desktop OS/Windows priority/P4 Planned work. We expect to get to it "soon".

Comments

@TheJanox824
Copy link

Description

All new tab background image related options are missing from the "Customise Dashboard".

Steps to Reproduce

  1. Go to new tab
  2. Click on "Customise"
  3. See there is no background image tab.

Actual result:

There are no options related to the background image.
image

Expected result:

I saw screenshots where there's a background image tab, with options to change background, solid color, show sponsored images, or no image at all.

Reproduces how often:

The option is just not there. I never had it in the first place.

Brave version (brave://version info)

Brave: 1.46.140 Chromium: 108.0.5359.99 (Official Build) (64-bit)
Revision: 410951fc34bb4b2cbf182231f9f779efaafaf682-refs/branch-heads/5359_71@{#9}
OS: Windows 10 Version 22H2 (Build 19045.2311)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes (the one I'm using rn)
  • Can you reproduce this issue with the beta channel? Yes (I tried this)
  • Can you reproduce this issue with the nightly channel? Yes (I tried this)

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? No

Miscellaneous Information:

I already tried removing all my extensions, reinstalling the browser, creating a new profile, I even tried on a fresh Windows installation, and a VM, and it's the same. I also tried disabling hardware acceleration (--disable-gpu in shortcut), with no success. This issue is not present on my Ubuntu installation (Brave Flatpak), with the proprietary NVIDIA drivers.

@rebron
Copy link
Collaborator

rebron commented Dec 12, 2022

@TheJanox824 A couple questions for you. Can you you take a screenshot of the new tab page you have now? Open a new tab and take a screenshot for me. Also, can you tell me what locale or region you're in.

I just checked on 1.46.140 and I'm not seeing what you're seeing, so possibly extension related although you mentioned you turned off Extensions.

@rebron
Copy link
Collaborator

rebron commented Dec 12, 2022

cc: @sangwoo108

@TheJanox824
Copy link
Author

@rebron It was a Windows regional format problem, I had it set to English (World), I changed it to English (United Kingdom) in Windows settings, and it appears to have solved the issue, background image options finally appeared. Thanks!

Should I close this issue? While the problem on my side is fixed, I still find it weird that this particular feature doesn't work when the system locale is English (World). Looks like a bug.

@rebron
Copy link
Collaborator

rebron commented Dec 13, 2022

@TheJanox824 Keep it open. I think we may have wrapped the setting incorrectly here by locale at the wrong level. Should still be able to change background images no matter what locale setting.

@rebron
Copy link
Collaborator

rebron commented Dec 13, 2022

cc: @simonhong
Note to check if this is a super referral issue.

@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Dec 13, 2022
@simonhong
Copy link
Member

simonhong commented Dec 14, 2022

cc: @simonhong Note to check if this is a super referral issue.

We're not allowing background customization when super referral now.
Oh, it looks ads enabled region or not could affect this. checking.

@simonhong
Copy link
Member

Closed as duplicated with #28144

@simonhong simonhong added the closed/duplicate Issue has already been reported label Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported feature/new-tab feature/settings needs-investigation A bug not 100% confirmed/fixed OS/Desktop OS/Windows priority/P4 Planned work. We expect to get to it "soon".
Projects
None yet
Development

No branches or pull requests

3 participants