Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose SNS feature flag via brave:://flags #27378

Closed
yrliou opened this issue Dec 14, 2022 · 1 comment · Fixed by brave/brave-core#16381
Closed

Expose SNS feature flag via brave:://flags #27378

yrliou opened this issue Dec 14, 2022 · 1 comment · Fixed by brave/brave-core#16381
Assignees
@supermassive
Labels
feature/web3/ddns feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.48.x - Release

Comments

@yrliou
Copy link
Member

yrliou commented Dec 14, 2022

AFAIK right now we can only enable it via command line, it would be better to have an entry in brave://flags for users who want to try it. cc @supermassive @lukaslevert
@yrliou yrliou added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop feature/web3/wallet/core feature/web3/ddns labels Dec 14, 2022
@yrliou yrliou added this to Web3 Dec 14, 2022
@yrliou yrliou moved this to Backlog in Web3 Dec 14, 2022
@supermassive supermassive mentioned this issue Dec 15, 2022
Merged
25 tasks
Repository owner moved this from Backlog to Done in Web3 Dec 16, 2022
@brave-builds brave-builds added this to the 1.48.x - Nightly milestone Dec 16, 2022
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.48.141 Chromium: 109.0.5414.119 (Official Build) beta (64-bit)
Revision 772095164c7d5d4e73160f858efed3b5e87eca83-refs/branch-heads/5414@{#1458}
OS Linux
  • Verified steps from brave/brave-core#16381
  • Verified new flag brave://flags/#brave-wallet-sns is available and defaulted to disable
  • Verified enabling the flag shows the setting under Web3
  • Verified able to resolve .sol address
27378.mp4

Verification passed on

Brave 1.48.141 Chromium: 109.0.5414.119 (Official Build) beta (64-bit)
Revision 772095164c7d5d4e73160f858efed3b5e87eca83-refs/branch-heads/5414@{#1458}
OS Windows 11 Version 22H2 (Build 22621.755)
  • Verified steps from brave/brave-core#16381
  • Verified new flag brave://flags/#brave-wallet-sns is available and defaulted to disable
  • Verified enabling the flag shows the setting under Web3
  • Verified able to resolve .sol address
27378.mp4

Verification passed on

Brave 1.48.141 Chromium: 109.0.5414.119 (Official Build) beta (arm64)
Revision 772095164c7d5d4e73160f858efed3b5e87eca83-refs/branch-heads/5414@{#1458}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#16381
  • Verified new flag brave://flags/#brave-wallet-sns is available and defaulted to disable
  • Verified enabling the flag shows the setting under Web3
  • Verified able to resolve .sol address
27378.mov

@Uni-verse Uni-verse mentioned this issue Feb 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@supermassive supermassive

Labels
feature/web3/ddns feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.48.x - Release
Development

Successfully merging a pull request may close this issue.

Sns pref for android brave/brave-core
4 participants
@supermassive @yrliou @srirambv @brave-builds