Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable ENS L2 support for android. #27465

Closed
supermassive opened this issue Dec 20, 2022 · 1 comment · Fixed by brave/brave-core#16453
Closed

Enable ENS L2 support for android. #27465

supermassive opened this issue Dec 20, 2022 · 1 comment · Fixed by brave/brave-core#16453
Assignees
@supermassive
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.48.x - Release

Comments

@supermassive
Copy link

Needs UI similar to desktop one
image
@supermassive supermassive added QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality labels Dec 20, 2022
@supermassive supermassive self-assigned this Dec 20, 2022
@supermassive supermassive mentioned this issue Dec 26, 2022
Merged
25 tasks
@brave-builds brave-builds added this to the 1.48.x - Nightly milestone Dec 29, 2022
@LaurenWags LaurenWags added the feature/web3/wallet Integrating Ethereum+ wallet support label Jan 27, 2023
@srirambv
Copy link
Contributor

srirambv commented Feb 6, 2023 •
edited
Loading

Verification passed on the following devices running 1.48.155

  • Verified steps from brave/brave-core#16453
  • Verified new sub-menu is available for ENS L2 under Brave Shields and Privacy -> Ethereum Name Services
  • Verified setting it to Ask shows confirmation of using offchain lookup
Oppo Reno 5 (Android 13) Lenovo Tab (Android 12)
27465-ARM.mp4
27465-Tab.mp4

@srirambv srirambv added this to Web3 Feb 6, 2023
@srirambv srirambv moved this to Done in Web3 Feb 6, 2023
This was referenced Feb 7, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@supermassive supermassive

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.48.x - Release
Development

Successfully merging a pull request may close this issue.

ENS offchain support for android brave/brave-core
4 participants
@supermassive @srirambv @LaurenWags @brave-builds