Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widget Introduction #27648

Closed
anthonypkeane opened this issue Jan 4, 2023 · 3 comments · Fixed by brave/brave-core#17565
Closed

Widget Introduction #27648

anthonypkeane opened this issue Jan 4, 2023 · 3 comments · Fixed by brave/brave-core#17565
Assignees
@deeppandya
Labels
feature/widgets OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/include
Milestone
1.50.x - Release

Comments

@anthonypkeane
Copy link

Description

Please move this introduction of the Widget to session 25

210654252-42301968-f97a-40ed-acdb-41835698f982

Related to: https://github.com/brave/internal/issues/942

cc @timchilds
@anthonypkeane anthonypkeane added the OS/Android Fixes related to Android browser functionality label Jan 4, 2023
@timchilds
Copy link

Introduce the widget after 25 background to foreground opens. @deeppandya

@deeppandya deeppandya mentioned this issue Mar 10, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.51.x - Nightly milestone Mar 21, 2023
@brave-builds brave-builds mentioned this issue Mar 23, 2023
Merged
7 tasks
@kjozwiak
Copy link
Member

kjozwiak commented Apr 4, 2023

The above requires 1.50.113 or higher for 1.50.x verification 👍

@GeetaSarvadnya
Copy link

Verification PASSED on Vivo X70 Pro version 12 running Bravemonoarm64.1pk_1.50.113

App Restart

  • Verified closing and relaunching the app ~25 times and setting focus to URL bar shows the widget promo dialog
  • Also verified in between 25 restarts, setting focus to URL bar there was no promo dialog was shown. Only shows after the threshold is hit

App Switch

  • Verified switching between Brave and other apps ~25 times and setting focus to URL bar shows the widget promo dialog
  • Also verified in between 25 app switching, setting focus to URL bar there was no promo dialog was shown. Only shows after the threshold is hit

@kjozwiak kjozwiak mentioned this issue Apr 6, 2023
Closed
@kjozwiak kjozwiak mentioned this issue May 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

Labels
feature/widgets OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/include
Projects
None yet
Milestone
1.50.x - Release
Development

Successfully merging a pull request may close this issue.

Show widget promo after 25 app opens brave/brave-core
7 participants
@kjozwiak @deeppandya @anthonypkeane @Uni-verse @timchilds @GeetaSarvadnya @brave-builds