Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make a flag to suppress tab switching with mouse wheel #27694

Closed
sangwoo108 opened this issue Jan 8, 2023 · 1 comment · Fixed by brave/brave-core#16575
Closed

Make a flag to suppress tab switching with mouse wheel #27694

sangwoo108 opened this issue Jan 8, 2023 · 1 comment · Fixed by brave/brave-core#16575
Assignees
@sangwoo108
Labels
OS/Desktop OS/Linux priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA/Yes release-notes/exclude
Milestone
1.49.x - Release

Comments

@sangwoo108
Copy link

sangwoo108 commented Jan 8, 2023 •
edited
Loading

On linux, users can switch the active tab with wheel scroll. But for some users, it feels annoying. so it'd be good to have a flag to disable that.

Requested from brave/brave-core#16501 (comment)
@sangwoo108 sangwoo108 added OS/Linux priority/P4 Planned work. We expect to get to it "soon". release-notes/exclude labels Jan 8, 2023
@sangwoo108 sangwoo108 self-assigned this Jan 8, 2023
This was referenced Jan 8, 2023
Merged
Merged
@brave-builds brave-builds added this to the 1.49.x - Nightly milestone Jan 10, 2023
@btlechowski
Copy link

Verification passed on

Brave 1.49.118 Chromium: 111.0.5563.50 (Official Build) (64-bit)
Revision 39f3dfc5023fe60997adc4f6cf5439cfa3e6968a-refs/branch-heads/5563@{#903}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#16575

tab scrolling enabled

Steps:

  1. Enable brave://flags/#brave-vertical-tabs
  2. Enable brave://flags/#brave-change-active-tab-on-scroll-event
  3. Open few NTP
  4. hover over tab bar and move your mouse wheel

image

Verified able to switch tabs with mouse wheel

27694

tab scrolling disabled

Steps:

  1. Enable brave://flags/#brave-vertical-tabs
  2. Disable brave://flags/#brave-change-active-tab-on-scroll-event
  3. Open few NTP
  4. hover over tab bar and move your mouse wheel

image

Verified unable to switch tabs with mouse wheel

@btlechowski btlechowski mentioned this issue Mar 3, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sangwoo108 sangwoo108

Labels
OS/Desktop OS/Linux priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.49.x - Release
Development

Successfully merging a pull request may close this issue.

Make a flag to disable "Change tab on scroll events" brave/brave-core
4 participants
@sangwoo108 @LaurenWags @btlechowski @brave-builds