Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link has incorrect color on Rewards page #27799

Closed
zenparsing opened this issue Jan 13, 2023 · 3 comments · Fixed by brave/brave-core#16672
Closed

Link has incorrect color on Rewards page #27799

zenparsing opened this issue Jan 13, 2023 · 3 comments · Fixed by brave/brave-core#16672

Comments

@zenparsing
Copy link

Description

The "learn more" link in the Rewards summary box on the Rewards page is rendered with the incorrect color.

Steps to Reproduce

  1. Using a "grandfathered unverified" profile (account created in 1.47 or earlier).
  2. Navigate tobrave://rewards.

Actual result:

Screen Shot 2023-01-13 at 12 10 20 PM

Expected result:

The "learn more" link should be white.

Reproduces how often:

Easily reproduced

Desktop Brave version:

1.48.x

@kjozwiak
Copy link
Member

The above requires 1.48.132 or higher for 1.48.x verification 👍

@stephendonner
Copy link

stephendonner commented Jan 20, 2023

Verified PASSED using 1.48.134, Chromium 109.0.5414.87 on a Google Pixel XL running Android 9.

Steps:

  1. installed 1.47.161
  2. launched Brave
  3. enabled Brave Rewards
  4. installed 1.48.134 atop 1.47.161 (both are beta-channel builds)
  5. launched Brave
  6. opened brave://rewards
  7. examined and clicked on the Learn more link

Confirmed correct Learn more link color is white and links to https://brave.com/brave-rewards/

Learn more link brave.com/brave-rewards
Screenshot_20230120-190014 Screenshot_20230120-160217

@stephendonner stephendonner added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jan 20, 2023
@stephendonner
Copy link

Verified PASSED using

Brave 1.48.137 Chromium: 109.0.5414.87 (Official Build) beta (x86_64)
Revision 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS macOS Version 11.7.2 (Build 20G1020)

Steps:

  1. installed 1.47.161
  2. launched Brave
  3. enabled Brave Rewards
  4. installed 1.48.137 atop 1.47.161 (both are beta-channel builds)
  5. launched Brave
  6. opened brave://rewards
  7. examined and clicked on the Learn more link

Confirmed the -- Learn more link is white and goes to https://brave.com/rewards-changes/

brave://rewards https://brave.com/rewards-changes/
Screen Shot 2023-01-23 at 1 44 37 PM Screen Shot 2023-01-23 at 1 50 38 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants