Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update "Verified creator" blue checkmark icon #28208

Closed
5 tasks done
Miyayes opened this issue Feb 1, 2023 · 5 comments · Fixed by brave/brave-core#18442
Closed
5 tasks done

Update "Verified creator" blue checkmark icon #28208

Miyayes opened this issue Feb 1, 2023 · 5 comments · Fixed by brave/brave-core#18442
Assignees
@zenparsing
Labels
feature/P2P-Send feature/rewards OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Milestone
1.56.x - Release

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Feb 1, 2023 •
edited
Loading

Description

Update verified creator icon wherever it appears.

Tasks
Beta Give feedback

New:
image

Figma: https://www.figma.com/file/2c2RfbIJBzxwa2BXqSLyE0/P2P-Tipping?node-id=1%3A17&t=g8lHMQD7OIO5Evye-0

Perhaps coordinate with @zenparsing who will be working on the #28148 (new tipping banner).
@Miyayes Miyayes added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 1, 2023
@Miyayes Miyayes mentioned this issue Feb 1, 2023
Closed
@Miyayes Miyayes assigned zenparsing and unassigned mkarolin Feb 2, 2023
@Miyayes Miyayes mentioned this issue Mar 16, 2023
Closed
@Miyayes Miyayes added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Apr 18, 2023
@zenparsing zenparsing mentioned this issue May 12, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.53.x - Nightly milestone May 22, 2023
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented May 31, 2023 •
edited
Loading

@Miyayes @zenparsing In beta the icon is overlapping on the BAT logo but in the issue description, there is quite some space between both icons. Just wanted to know which one correct spec or the issue description? Thanks!

cc: @LaurenWags

Beta - 1.53.x Spec Description
image image image

@Miyayes
Copy link
Collaborator Author

Miyayes commented May 31, 2023

Overlap is fine. @GeetaSarvadnya I'll update the issue description:

From figma:
image

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jun 1, 2023 •
edited
Loading

Verification PASSED on

Brave | 1.53.74 Chromium: 114.0.5735.53 (Official Build) beta (64-bit)
-- | --
Revision | c499d7ea22c8b2dba278465a5df7b86a8efa4e64-refs/branch-heads/5735@{#970}
OS | Windows 10 Version 22H2 (Build 19045.2965)

1. The Rewards icon in the address bar

  • Confirmed that the verified badge appears on the BAT icon in the address bar for verified creator
Light theme Dark theme
image image

2. The Rewards panel (creator view)

  • Confirmed that the verified creator in the BR panel has the verified badge for verified creator
Light theme Dark theme
image image
image image
image image

3. The Rewards page

  • Confirmed that verified badge is shown on the verified creators in brave://rewards page
Light theme Dark theme
image image

4. The tipping panel

  • Confirmed that the verified badge is shown in the tipping panel for the verified creators
Light theme Dark theme
image image
image image
image image
image image
image image
image image

5. Non-verified badge

  • Confirmed that the non-verified badge is shown in the tipping panel for the non-verified creators
Light theme Dark theme
image image

This was referenced Jun 5, 2023
Closed
Closed
@LaurenWags
Copy link
Member

LaurenWags commented Jun 8, 2023 •
edited
Loading

Verified with

Brave | 1.53.85 Chromium: 114.0.5735.110 (Official Build) beta (x86_64)
-- | --
Revision | 1c828682b85bbc70230a48f5e345489ec447373e-refs/branch-heads/5735_90@{#13}
OS | macOS Version 13.4 (Build 22F66)

Verified the test plan from brave/brave-core#18442

Encountered

1. The Rewards icon in the address bar

  • Confirmed that the verified badge appears on the BAT icon in the address bar for verified creator
Light theme Dark theme
1 2

2. The Rewards panel (creator view)

  • Confirmed that the verified creator in the BR panel has the verified badge for verified creator
Light theme Dark theme
1 2

3. The Rewards page

  • Confirmed that verified badge is shown on the verified creators in brave://rewards page
Light theme Dark theme
1 2

4. The tipping panel

  • Confirmed that the verified badge is shown in the tipping panel for the verified creators
Light theme Dark theme
1 2

5. Non-verified badge

  • Confirmed that the non-verified badge is shown in the tipping panel for the non-verified creators
Light theme Dark theme
1 2

@LaurenWags
Copy link
Member

LaurenWags commented Jun 9, 2023 •
edited
Loading

Verified with

Brave	1.53.87 Chromium: 114.0.5735.110 (Official Build) beta (64-bit) 
Revision	1c828682b85bbc70230a48f5e345489ec447373e-refs/branch-heads/5735_90@{#13}
OS	Linux

Verified the test plan from brave/brave-core#18442

Encountered

1. The Rewards icon in the address bar

  • Confirmed that the verified badge appears on the BAT icon in the address bar for verified creator
Light theme Dark theme
1 2

2. The Rewards panel (creator view)

  • Confirmed that the verified creator in the BR panel has the verified badge for verified creator
Light theme Dark theme
1 2

3. The Rewards page

  • Confirmed that verified badge is shown on the verified creators in brave://rewards page
Light theme Dark theme
1 2

4. The tipping panel

  • Confirmed that the verified badge is shown in the tipping panel for the verified creators
Light theme Dark theme
1 2

5. Non-verified badge

  • Confirmed that the non-verified badge is shown in the tipping panel for the non-verified creators
Light theme Dark theme
1 2

@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jun 9, 2023
@LaurenWags LaurenWags added QA Pass-Linux and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jun 9, 2023
@kjozwiak kjozwiak mentioned this issue Jun 21, 2023
Merged
25 tasks
@LaurenWags LaurenWags mentioned this issue Jul 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zenparsing zenparsing

Labels
feature/P2P-Send feature/rewards OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Milestone
1.56.x - Release
Development

Successfully merging a pull request may close this issue.

Use custom shape for creator verified badges brave/brave-core
7 participants
@kjozwiak @zenparsing @Miyayes @LaurenWags @GeetaSarvadnya @mkarolin @brave-builds