Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-discovery of assets resets the visible assets pref. #28749

Closed
jamesmudgett opened this issue Feb 24, 2023 · 2 comments · Fixed by brave/brave-core#18459
Closed

Auto-discovery of assets resets the visible assets pref. #28749

jamesmudgett opened this issue Feb 24, 2023 · 2 comments · Fixed by brave/brave-core#18459
Assignees
@Douglashdaniel
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.56.x - Release

Comments

@jamesmudgett
Copy link

jamesmudgett commented Feb 24, 2023 •
edited
Loading

Now that we have full asset auto-discovery of L2s setting an asset to hidden will be overwritten next time AD returns results. I'm setting USDC on Solana to hidden but seeing it return in my portfolio.
@jamesmudgett jamesmudgett converted this from a draft issue Feb 24, 2023
@jamesmudgett jamesmudgett added feature/web3/wallet/core priority/P3 The next thing for us to work on. It'll ride the trains. feature/web3/wallet Integrating Ethereum+ wallet support labels Feb 24, 2023
@jamesmudgett jamesmudgett moved this to Backlog in Web3 Feb 24, 2023
@Douglashdaniel Douglashdaniel added bug QA/Yes release-notes/include front-end-change This task is a front end task and doesn't need any C++ changes and removed feature/web3/wallet/core labels Feb 27, 2023
@diracdeltas diracdeltas added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Apr 27, 2023
@diracdeltas
Copy link
Member

diracdeltas commented Apr 27, 2023 •
edited
Loading

bumping to p2 due to the privacy concern: https://bravesoftware.slack.com/archives/C023VS4HJ6Q/p1682622628848399

@nuo-xu nuo-xu mentioned this issue May 11, 2023
Closed
@Douglashdaniel Douglashdaniel moved this from Backlog to In Progress in Web3 May 11, 2023
@Douglashdaniel Douglashdaniel mentioned this issue May 11, 2023
Merged
25 tasks
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 May 15, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 May 15, 2023
@brave-builds brave-builds added this to the 1.53.x - Nightly milestone May 15, 2023
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.53.102 Chromium: 114.0.5735.133 (Official Build) (64-bit)
Revision fbfa2ce68d01b2201d8c667c2e73f648a61c4f4a-refs/branch-heads/5735@{#1270}
OS Linux
  • Verified steps from issue description
  • Verified disabling a token from visible list and importing a new account to trigger auto-discover doesn't add the disabled token to visible list

Verification passed on

Brave 1.53.102 Chromium: 114.0.5735.133 (Official Build) (64-bit)
Revision fbfa2ce68d01b2201d8c667c2e73f648a61c4f4a-refs/branch-heads/5735@{#1270}
OS Windows 11 Version 22H2 (Build 22621.1848)
  • Verified steps from issue description
  • Verified disabling a token from visible list and importing a new account to trigger auto-discover doesn't add the disabled token to visible list

Verification passed on

Brave 1.53.102 Chromium: 114.0.5735.133 (Official Build) (64-bit)
Revision fbfa2ce68d01b2201d8c667c2e73f648a61c4f4a-refs/branch-heads/5735@{#1270}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from issue description
  • Verified disabling a token from visible list and importing a new account to trigger auto-discover doesn't add the disabled token to visible list

@LaurenWags LaurenWags mentioned this issue Jul 17, 2023
Closed
@StephenHeaps StephenHeaps mentioned this issue Jul 26, 2024
Merged
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.56.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): Allow Removing Auto Discovered Tokens brave/brave-core
6 participants
@jamesmudgett @diracdeltas @nvonpentz @srirambv @Douglashdaniel @brave-builds