Upgrade from Chromium 112 to Chromium 113.

[mkarolin]

Upgrade from Chromium 112 to Chromium 113

https://chromium.googlesource.com/chromium/src/+log/112.0.5615.20..113.0.5638.0/?pretty=fuller&n=10000

QA tests:
This is a major Chromium version bump, please do full passes.

Desktop Affected areas:

• Copying clean link in the sharing hub
• Tabs are styled correctly
• Vertical tabs on Windows (layout and general functionality)
• Settings webui (fonts look correctly, general functionality)
• Brave version in settings webui looks correctly
• Sync works correctly
• Side panel button works and has correct tooltips

iOS Affected areas:
TBD

Android Affected areas:

• Search engine options (big changes, double check it works properly for both regular and private tabs)
• Sync (double check it generally works)
• Rewards page

[GeetaSarvadnya]

Verification PASSED on

Brave | 1.52.68 Chromium: 113.0.5672.53 (Official Build) nightly (64-bit)
-- | --
Revision | 12f5dac35d12e8f4e72d7dd11df557ef93bc046f-refs/branch-heads/5672@{#703}
OS | Windows 10 Version 21H2 (Build 19044.2846)

Logged #29973
Logged #29964
Encounter #29929

Copying clean link in the sharing hub_PASSED

1. Confirmed "Copy clean link" is displayed in the share menu from URL bar
2. Confirm that Copy clean link is NOT shown for brave internal pages
3. Right-clicked the URL on any website and confirmed "Copy clean link" with Ctrl +C as the shortcut in the context menu
4. Used "Ctrl + C" while the URL bar is in focus to copy the URL
5. Opened a new tab and pasted the copied URL
6. Confirmed link pasted correcty
7. Confirmed that "Copy clean link" is displayed in the share menu from URL bar even when the flags #brave-copy-clean-link-by-default is disabled via brave://flags
8. Right-clicked the URL and confirmed "Copy clean link" is in the context menu
9. Used "Ctrl + C" while the URL bar is in focus to copy the URL
10. Opened a new tab and pasted the copied URL
11. Confirmed link pasted correcty

step 1	step 2	step 3	step 5	step 7	step 8	step 10

Tabs are styled correctly_PASSED

• Confirmed that Tab hover modes works as expected

Card	Card with Preview	Tooltip

Vertical tabs on Windows (layout and general functionality)_PASSED

Horizontal Tab orientation:_

• Confirmed that user can create a new tab group via Add tab to group ->New group
  

• Confirmed that tabs can be added to existing/already created tab groups
  

• Confired that click on the tab group name expands/list of all the tabs added in that group

Example	Example

• Confirmed that added tabs can be removed from the tab group via Remove from group
  

• Confirmed that user can ungroup the tabs via Ungroup
  

• Confirmed that grouped websites can be moved to new window via context menu Move group to new window

existing windows	new window

General testing on Vertical tabs :

• Confirmed that Use vertical tabs settings is added in Tabs section under brave://settings/appearance
• Confirmed that tabs orientation changed to vertical when user toggle the Use vertical tabs settings via brave://settings/appearance
• Verified that sites can be added to vertical tab by clicking on the + New tab or Ctrl+T
• Right click on any site added in the vertical tab shows the site context menu options
• Verified that reading list and vertical tabs cab be enabled at the same time
• Right click on any site and select Add tab to reading list context menu option and ensured site can be added to the reading list
• Right click on any site and select Add a tab to new group and ensured that the selected site can be added to new tab group
• Right click on the sites in vertical tab and select Add a tab to new group and then created tab (e.g test which I have created in my testing) group and ensured that sites got added to the tab group test
• Verified that created tab group can be collapsed/expanded, when the group is expanded sites added in tab groups are shown
• Right click on any site in vertical tab and select Move tab to another window and ensured that tab is opened in an new window
• When a tab is moved to the new window, if user try to move another tab to new window, user get option to move the tab to the existing (2nd window) or new window, ensured both options works fine
• Right click on any site in vertical tab and select Reload context menu option and ensured site gets reloaded/refreshed
• Right click on any site in vertical tab and select Duplicate context menu option and ensured duplicate tab got added to the tab group
• Right click on any site in vertical tab and select Pin context menu option and ensured site pinned in the tab group and right clicked on the pinned tab and ensured Unpin option is shown
• Ensured that pinned site can be unpinned by clicking on the Unpin option
• Right click on any YT site in vertical tab and select mute context menu option and ensured site is muted and mute option is shown in the URL bar and video is playing in an muted mode.
• Ensured that YT videos can be unmuted by clicking on the Unmute option
• Ensured that Close, Close other tabs, Close tabs to the right and Reopen closed tabs works as expected
• Ensured that the tab Bookmarls all context menu works as expected
• Ensured that tabs can be drag and drop in an vertical tab
• Ensured that vertical tab cab be collapsed/expanded, when vertical tabs is expand the tabs with site name and url is shown, when vertical tab cab be collapsed, the site favicons are shown in the vertical tabs

Toggle "Use Vertical tabs" settings ON/OFF

• Confirmed that Use Vertical tabs toggle ON/OFF works as expected
• Confirmed that once the Use Vertical tabs toggle is OFF, tabs are shown in horizontal view
• Confirmed that when tabs are switched between vertical/horizontal, the created tab groups are not lost
• Confirmed that when tabs are switched between vertical/horizontal, the pinned tabs are not lost

Example	Example

Show title bar

• Confirmed that title bar is shown when the Show title bar toggle is turned ON
• Confirmed that title bar is NOT shown when the Show title bar toggle is turned OFF

Example	Example	Example	Example

Float on mouseover

• Confirmed that Float on mouseover settings is enabled by default under brave://settings/appearance
• When vertical tabs are in minimized mode, mouseover on the vertical tabs shows the vertical tabs in floating mode
• Confirmed that mouseover on the vertical tabs DOESN'T shows the vertical tabs in floating mode when the settings Float on mouseover is unchecked
  

Tab hover mode

• Confirmed that Card Tab hover mode settings works as expected on vertical tabs
• Confirmed that Card with preview Tab hover mode settings works as expected on vertical tabs
• Confirmed that Tooltip Tab hover mode settings works as expected on vertical tabs
  

Show tab search button

• Confirmed that Show tab search button settings works as expected with Vertical tabs enable
• Confirmed that able to search particula tabs using search tab option
  

Settings webui (fonts look correctly, general functionality)_PASSED

• Testing is covered in the Settings comparison below

Brave version in settings webui looks correctly_PASSED

• Confirmed that Brave version is shown correctly in brave://settings, brave://settings/help and brave://version

brave://settings	brave://settings/help	brave://version

Sync works correctly_PASSED

• Performed the general sync testing on 1.52.x and ensured that sync works as expected
• Synced 1.52.x with 2 - desktop devices, 2 - Android devices and 1- iPhone
• Ensured that bookmarks, passwords and tabs from all the devices are synced
• Ensured removing one device from the sync chain removes the device from all the devices
• Ensured removing a bookmark from one device, removes the bookmark from all the synced devices

1.52.x

Side panel button works and has correct tooltips_PASSED

• Confirmed that sidebar is shown by default in the nightly channel
• Confirmed that Reading list icon is added to the sidebar menu
• Confirmed that reading list panel is shown when user click on the Reading list icon in the sidebar menu
• Confirmed that user can add the list of websites to the reading list by clicking on the +Add current tab
• Confirmed that user can add the list of websites to the reading list by right clicking on the tab and choose the option Add tab to the reading list
• Confirmed that reading list panel can be hidden by clicking on the Reading list icon in the sidebar menu
• Confirmed that reading list icon is shown in the URL bar, next to wallet icon
• Confirmed that user can enable/disable the reading list by clicking on the reading list icon (shown in the URL bar)
• Confirmed that reading list is shown in all the window types (Normal, PT, TOR and Guest window)
• Websites can't be added to reading list in Guest, encountered Unable to add a site to reading list in Guest window as Add to current tab option is not getting activated #24930
• Confirmed that sites can be segregated to Read and Unread list
• Confirmed that sites can be deleted from the reading list
• Confirmed that tooltip is shown correctly for each menu item in sidebar
• Confirmed that click on each sidepanel button Brave Talk, wallet, Bookmarks and REading list works as expected

Sidebar Tooltips

Brave talk	wallet	Bookmarks	Reading list	Add to sidebar +	Show settings	website tool tip

---

Settings comparison

• No new settings are added as part of CR 113

• New settings Use vertical tabs is added as part of Brave, settings which are related to tabs are listed/rearranged and shown under the Tabs section under brave://settings/appearance
  

• The New Tab Page settings Customize the background image and widgets that appear on the new tab page is renamed to Customize new tab page. Confirm that click on the settings opens up the dashboard settings in NTP

Example	Example

• New settings are added in wallet and IPFS sections as part of brave

wallet	IPFS

• Brave Translate settings is added under brave://settings/languages
  

• New content setting Cookies and site data is added under brave://settings/cookies/detail?site=xyz.com as part of Brave (more details Added back Chromium implementation of views to look for individual cookies stored per-website. brave-core#17746)

Example	Example

Components updater

• No new components are added as part of CR 112
• Components are updates successfully without any error

1.50.121 Chromium: 112.0.5615.138	1.52.68 Chromium: 113.0.5672.53

Brave startup calls

• Confirmed that only brave domains are listed in the Charles when the nightly build is launched with a clean profile
• Confirmed no calls to google, gstatic, etc domains when the nightly build is launched with a clean profile

[hffvld]

Verified on Google Pixel 6 and Samsung A32 5G using version(s):

Device/OS:
- Google Pixel 6 [oriole-user 12 SQ1D.220205.004.X2 release-keys]
- Samsung A32 5G [a32xsq-user 13 TP1A.220624.014 release-keys]
Brave build: 1.52.69, Chromium: 113.0.5672.53 (Official Build) canary (64-bit) 
Revision: 12f5dac35d12e8f4e72d7dd11df557ef93bc046f-refs/branch-heads/5672@{#703}

Search Engine options - PASS

• Verified different Search Engines are working
• Verified in Standard and Private tabs
• Verified after closing/relaunching and after upgrade is done

1	2	3

Sync - PASS

• Verified Sync is working on clean and upgraded profile
• Verified user is able to create a standalone sync chain
• Verified that adding other devices to the sync chain is successful
• Verified data is being synced to other devices
• Verified user is able to join existing sync chain using code words and by scanning QR
• Verified that deleting sync chain works

1	2	3

Rewards page - PASS

• Verified that user is able to join to rewards on clean and upgraded profile
• Verified that user is able to receive ad grants
• Verified that user is able to tip creators
• Verified that Auto Contribute works
• Verified that brave://rewards page displays information correctly and user is able to change settings
• Verified that brave://rewards-internals shows correct rewards data

1	2	3

NOTE: Filed new issue [Rewards] Tip amount is not shown for both One-time and Monthly tip #29981 that is not related to C113 upgrade

[Uni-verse]

Verified on Samsung Galaxy Tab S7 using version(s):

Brave	1.52.69 Chromium: 113.0.5672.53 (Official Build) canary (64-bit) 
Revision	12f5dac35d12e8f4e72d7dd11df557ef93bc046f-refs/branch-heads/5672@{#703}
OS	Android 13; Build/TP1A.220624.014; 33; REL

• Completed a spot check for SE options, Sync and Rewards when upgrading to Chromium 113

Example	Example

[kjozwiak]

The above requires 1.51.106 or higher for 1.51.x verification 👍

[btlechowski]

Verification passed on

Brave	1.51.106 Chromium: 113.0.5672.53 (Official Build) (64-bit)
Revision	12f5dac35d12e8f4e72d7dd11df557ef93bc046f-refs/branch-heads/5672@{#703}
OS	Ubuntu 18.04 LTS

Verified the areas mentioned in the description

Copying clean link in the sharing hub PASSED

1. Confirmed "Copy clean link" is displayed in the share menu from URL bar
2. Confirm that Copy clean link is NOT shown for brave internal pages
3. Right-clicked the URL on any website and confirmed "Copy clean link" with Ctrl +C as the shortcut in the context menu
4. Used "Ctrl + C" while the URL bar is in focus to copy the URL
5. Opened a new tab and pasted the copied URL
6. Confirmed link pasted correctly
7. Confirmed that "Copy clean link" is displayed in the share menu from URL bar even when the flags #brave-copy-clean-link-by-default is disabled via brave://flags
8. Right-clicked the URL and confirmed "Copy clean link" is in the context menu
9. Used "Ctrl + C" while the URL bar is in focus to copy the URL
10. Opened a new tab and pasted the copied URL
11. Confirmed link pasted correctly

Tabs are styled correctly PASSED

• Confirmed that Tab hover modes works as expected

Card	Card with Preview	Tooltip

Vertical tabs (layout and general functionality)_PASSED

Horizontal Tab orientation:_

• Confirmed that user can create a new tab group via Add tab to group ->New group
  

• Confirmed that tabs can be added to existing/already created tab groups
  

• Confirmed that click on the tab group name expands/list of all the tabs added in that group

• Confirmed that added tabs can be removed from the tab group via Remove from group
  

• Confirmed that user can ungroup the tabs via Ungroup
  

• Confirmed that grouped websites can be moved to new window via context menu Move group to new window

General testing on Vertical tabs :

• Confirmed that Use vertical tabs settings is added in Tabs section under brave://settings/appearance
• Confirmed that tabs orientation changed to vertical when user toggle the Use vertical tabs settings via brave://settings/appearance
• Verified that sites can be added to vertical tab by clicking on the + New tab or Ctrl+T
• Right click on any site added in the vertical tab shows the site context menu options
• Verified that reading list and vertical tabs cab be enabled at the same time
• Right click on any site and select Add tab to reading list context menu option and ensured site can be added to the reading list
• Right click on any site and select Add a tab to new group and ensured that the selected site can be added to new tab group
• Right click on the sites in vertical tab and select Add a tab to new group and then created tab (e.g test which I have created in my testing) group and ensured that sites got added to the tab group test
• Verified that created tab group can be collapsed/expanded, when the group is expanded sites added in tab groups are shown
• Right click on any site in vertical tab and select Move tab to another window and ensured that tab is opened in an new window
• When a tab is moved to the new window, if user try to move another tab to new window, user get option to move the tab to the existing (2nd window) or new window, ensured both options works fine
• Right click on any site in vertical tab and select Reload context menu option and ensured site gets reloaded/refreshed
• Right click on any site in vertical tab and select Duplicate context menu option and ensured duplicate tab got added to the tab group
• Right click on any site in vertical tab and select Pin context menu option and ensured site pinned in the tab group and right clicked on the pinned tab and ensured Unpin option is shown
• Ensured that pinned site can be unpinned by clicking on the Unpin option
• Right click on any YT site in vertical tab and select mute context menu option and ensured site is muted and mute option is shown in the URL bar and video is playing in an muted mode.
• Ensured that YT videos can be unmuted by clicking on the Unmute option
• Ensured that Close, Close other tabs, Close tabs to the right and Reopen closed tabs works as expected
• Ensured that the tab Bookmarls all context menu works as expected
• Ensured that tabs can be drag and drop in an vertical tab
• Ensured that vertical tab cab be collapsed/expanded, when vertical tabs is expand the tabs with site name and url is shown, when vertical tab cab be collapsed, the site favicons are shown in the vertical tabs

Toggle "Use Vertical tabs" settings ON/OFF

• Confirmed that Use Vertical tabs toggle ON/OFF works as expected
• Confirmed that once the Use Vertical tabs toggle is OFF, tabs are shown in horizontal view
• Confirmed that when tabs are switched between vertical/horizontal, the created tab groups are not lost
• Confirmed that when tabs are switched between vertical/horizontal, the pinned tabs are not lost

Show title bar

• Confirmed that title bar is shown when the Show title bar toggle is turned ON
• Confirmed that title bar is NOT shown when the Show title bar toggle is turned OFF

Float on mouseover

• Confirmed that Float on mouseover settings is enabled by default under brave://settings/appearance
• When vertical tabs are in minimized mode, mouseover on the vertical tabs shows the vertical tabs in floating mode
• Confirmed that mouseover on the vertical tabs DOESN'T shows the vertical tabs in floating mode when the settings Float on mouseover is unchecked
  
  

Tab hover mode

• Confirmed that Card Tab hover mode settings works as expected on vertical tabs
• Confirmed that Card with preview Tab hover mode settings works as expected on vertical tabs
• Confirmed that Tooltip Tab hover mode settings works as expected on vertical tabs
  

Show tab search button

• Confirmed that Show tab search button settings works as expected with Vertical tabs enable
• Confirmed that able to search particular tabs using search tab option

Settings webui (fonts look correctly, general functionality)_PASSED

• Testing is covered in the Settings comparison below

Brave version in settings webui looks correctly_PASSED

• Confirmed that Brave version is shown correctly in brave://settings, brave://settings/help and brave://version

brave://settings	brave://settings/help	brave://version

Sync works correctly - PASSED

• Performed the general sync testing on 1.52.x and ensured that sync works as expected
• Synced 1.52.x with 2 - desktop devices, 1- iPhone
• Ensured that bookmarks, passwords and tabs from all the devices are synced
• Ensured removing one device from the sync chain removes the device from all the devices
• Ensured removing a bookmark from one device, removes the bookmark from all the synced devices

Side panel button works and has correct tooltips_PASSED

• Confirmed that sidebar is shown by default in the nightly channel
• Confirmed that Reading list icon is added to the sidebar menu
• Confirmed that reading list panel is shown when user click on the Reading list icon in the sidebar menu
• Confirmed that user can add the list of websites to the reading list by clicking on the +Add current tab
• Confirmed that user can add the list of websites to the reading list by right clicking on the tab and choose the option Add tab to the reading list
• Confirmed that reading list panel can be hidden by clicking on the Reading list icon in the sidebar menu
• Confirmed that reading list icon is shown in the URL bar, next to wallet icon
• Confirmed that user can enable/disable the reading list by clicking on the reading list icon (shown in the URL bar)
• Confirmed that reading list is shown in all the window types (Normal, PT, TOR and Guest window)
• Websites can't be added to reading list in Guest, encountered Unable to add a site to reading list in Guest window as Add to current tab option is not getting activated #24930
• Confirmed that sites can be segregated to Read and Unread list
• Confirmed that sites can be deleted from the reading list
• Confirmed that tooltip is shown correctly for each menu item in sidebar
• Confirmed that click on each sidepanel button Brave Talk, wallet, Bookmarks and REading list works as expected

Sidebar Tooltips

Brave talk	wallet	Bookmarks	Reading list	Add to sidebar +	Show settings	website tool tip

[kjozwiak]

Labelling as QA/No and release-notes/exclude in favour of #30025. Summary of the work remaining can be found via #30025 (comment).