Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Phantom derivation paths for Solana hardware accounts #29186

Closed
nvonpentz opened this issue Mar 20, 2023 · 1 comment · Fixed by brave/brave-core#18319
Closed

Support Phantom derivation paths for Solana hardware accounts #29186

nvonpentz opened this issue Mar 20, 2023 · 1 comment · Fixed by brave/brave-core#18319
Assignees
@nvonpentz
Labels
feature/web3/wallet/solana feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.56.x - Release

Comments

@nvonpentz
Copy link
Member

When using importing a Solana hardware account, I should be able choose the derivation path(s) I used when using Phantom. This may have partially been implemented in brave/brave-core#15406 which solves #25111, however we have confirmed recent reports that Phantom derivation path(s) are not supported at least by the frontend.
@nvonpentz nvonpentz added this to Web3 Mar 20, 2023
@HEagle18 HEagle18 added the priority/P3 The next thing for us to work on. It'll ride the trains. label Mar 24, 2023
@HEagle18 HEagle18 moved this to Backlog in Web3 Mar 24, 2023
@nvonpentz nvonpentz mentioned this issue May 1, 2023
Merged
25 tasks
@github-project-automation github-project-automation bot moved this from Backlog to Done in Web3 May 4, 2023
@brave-builds brave-builds added this to the 1.53.x - Nightly milestone May 4, 2023
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.53.94 Chromium: 114.0.5735.133 (Official Build) beta (64-bit)
Revision fbfa2ce68d01b2201d8c667c2e73f648a61c4f4a-refs/branch-heads/5735@{#1270}
OS Windows 11 Version 22H2 (Build 22621.1848)
  • Verified steps from brave/brave-core#18319
  • Verified able to import accounts from all available derivation paths available
29186.mp4

@LaurenWags LaurenWags mentioned this issue Jul 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nvonpentz nvonpentz

Labels
feature/web3/wallet/solana feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.56.x - Release
Development

Successfully merging a pull request may close this issue.

Add missing Solana derivation path brave/brave-core
4 participants
@HEagle18 @nvonpentz @srirambv @brave-builds