Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept-Language headers in service workers are missing a farbled weight #29372

Closed
pes10k opened this issue Mar 28, 2023 · 6 comments · Fixed by brave/brave-core#18756
Closed

Accept-Language headers in service workers are missing a farbled weight #29372

pes10k opened this issue Mar 28, 2023 · 6 comments · Fixed by brave/brave-core#18756
Assignees
@pilgrim-brave
Labels
feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. privacy/feature User-facing privacy- & security-focused feature work. privacy/tracking Preventing sites from tracking users across the web QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android 8+ QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Milestone
1.57.x - Release

Comments

@pes10k
Copy link
Contributor

pes10k commented Mar 28, 2023

https://dev-pages.brave.software/fingerprinting/exceptions.html shows the issue

requests issued from service workers is missing a farbled weight value (i.e., the q=.[0-9]).
@pes10k pes10k added OS/Android Fixes related to Android browser functionality OS/Desktop privacy/feature User-facing privacy- & security-focused feature work. privacy/tracking Preventing sites from tracking users across the web feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields labels Mar 28, 2023
@ShivanKaul ShivanKaul added the priority/P3 The next thing for us to work on. It'll ride the trains. label Apr 25, 2023
@pilgrim-brave
Copy link

Unable to reproduce this with latest local build. Perhaps this was fixed?
Screenshot 2023-06-02 at 11 09 47 AM

@pes10k
Copy link
Contributor Author

pes10k commented Jun 2, 2023

I'm still seeing on 1.54.22

@pilgrim-brave
Copy link

OK yes I've reproduced it now on a local build.

@pilgrim-brave pilgrim-brave mentioned this issue Jun 5, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.54.x - Nightly milestone Jun 15, 2023
@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jul 3, 2023
@stephendonner
Copy link

stephendonner commented Jul 3, 2023 •
edited by GeetaSarvadnya
Loading

Verified PASSED using

Brave 1.54.90 Chromium: 115.0.5790.56 (Official Build) beta (x86_64)
Revision ebcfb87c1393f36955cfa2f6451a1767e3dc3ee5-refs/branch-heads/5790@{#1193}
OS macOS Version 14.0 (Build 23A5276g)

Steps:

  1. installed 1.54.90
  2. launched Brave
  3. loaded https://dev-pages.brave.software/fingerprinting/exceptions.html
  4. clicked Start tests
  5. noted the values for Service Workers Default fetch were en-US,en;q=0.7
  6. compared to 1.53.107

Confirmed the Accept-Language headers now have farbling weights, for Service Workers, as shown

https://dev-pages.brave.software/fingerprinting/exceptions.html

1.53.107 1.54.90
Screenshot 2023-07-03 at 4 07 13 PM Screenshot 2023-07-03 at 4 07 55 PM

https://dev-pages.bravesoftware.com/fingerprinting/exceptions.html

1.53.107 1.54.90
Screenshot 2023-07-03 at 4 18 51 PM Screenshot 2023-07-03 at 4 17 10 PM

Verification PASSED on

Brave	1.57.33 Chromium: 115.0.5790.114 (Official Build) beta (64-bit) 
Revision	86b4ea1d70ce73c4468d84cc8277f1f9de14b8bc
OS	Linux

Steps:

  1. installed 1.57.x
  2. launched Brave
  3. loaded https://dev-pages.brave.software/fingerprinting/exceptions.html
  4. clicked Start tests
  5. noted the values for Service Workers Default fetch were en-US,en;q=0.7
  6. compared to 1.56.x

Confirmed the Accept-Language headers now have farbling weights, for Service Workers, as shown

https://dev-pages.brave.software/fingerprinting/exceptions.html

1.56.x 1.57.x
image image

https://dev-pages.bravesoftware.com/fingerprinting/exceptions.html

1.56.x 1.57.x
image image

@stephendonner stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jul 3, 2023
@GeetaSarvadnya GeetaSarvadnya added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-Linux and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Aug 4, 2023
@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Aug 4, 2023
@hffvld
Copy link
Contributor

hffvld commented Aug 4, 2023

Verified on Pixel 2 XL, Galaxy Tab S8 and Pixel 7 using version(s):

Device/OS: 
- Pixel 2 XL [taimen-user  8.1.0 OPM2.171026.006.H1 release-keys]
- Galaxy Tab S8 [gts8wifixx-user 13 TP1A.220624.014 release-keys]
- Pixel 7 [panther_beta-user 14 UPB4.230623.007 release-keys]
Brave build: 1.57.35
Chromium: 115.0.5790.171 (Official Build) beta (64-bit) 
Revision: 776897328898241b35b83878040730e73e749c06

STEPS:

  1. Launch Brave
  2. Open https://dev-pages.brave.software/fingerprinting/exceptions.html
  3. Tap Start tests > Verify
  4. Open https://dev-pages.bravesoftware.com/fingerprinting/exceptions.html
  5. Tap Start tests > Verify

ACTUAL RESULTS:

  • Verified that the Accept-Language headers now have farbling weights for Service Workers
Android 8 [phone] Android 13 [tablet] Android 14 [phone]
1 2 3
1 2 3

@hffvld hffvld added QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android 8+ and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Aug 4, 2023
@MadhaviSeelam
Copy link

Verifcation PASSED using

Brave | 1.57.41 Chromium: 115.0.5790.171 (Official Build) beta (64-bit)
-- | --
Revision | adc7e3e2defac3f9b39cb22bcbb354b72b74c2eb
OS | Windows 11 Version 22H2 (Build 22621.1992)

Steps:

  1. installed 1.57.41
  2. launched Brave
  3. loaded https://dev-pages.brave.software/fingerprinting/exceptions.html
  4. clicked Start tests
  5. noted the values for Service Workers Default fetch were en-US,en;q=0.7
  6. compared to 1.56.20

Confirmed the Accept-Language headers now have farbling weights, for Service Workers, as shown

https://dev-pages.brave.software/fingerprinting/exceptions.html

1.56.20 1.57.41
image image

https://dev-pages.bravesoftware.com/fingerprinting/exceptions.html

1.56.20 1.57.41
image image

@LaurenWags LaurenWags mentioned this issue Aug 11, 2023
Closed
@kjozwiak kjozwiak mentioned this issue Aug 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pilgrim-brave pilgrim-brave

Labels
feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. privacy/feature User-facing privacy- & security-focused feature work. privacy/tracking Preventing sites from tracking users across the web QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android 8+ QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Milestone
1.57.x - Release
Development

Successfully merging a pull request may close this issue.

Set reduce-lang origin correctly in service workers brave/brave-core
9 participants
@pes10k @stephendonner @ShivanKaul @LaurenWags @GeetaSarvadnya @pilgrim-brave @brave-builds @MadhaviSeelam @hffvld