Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Wallet) Integrate multichain support for NFT grid #29444

Closed
simoarpe opened this issue Mar 31, 2023 · 1 comment · Fixed by brave/brave-core#17967
Closed

(Wallet) Integrate multichain support for NFT grid #29444

simoarpe opened this issue Mar 31, 2023 · 1 comment · Fixed by brave/brave-core#17967
Assignees
@simoarpe
Labels
feature/web3/wallet/nft feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.52.x - Release

Comments

@simoarpe
Copy link

simoarpe commented Mar 31, 2023 •
edited by srirambv
Loading

Description

Integrates multichain support for NFT grid screen.

Other changes:

  • Adds network icons to the lower right side for NFT items shown in the grid.
  • Includes plus icon as a menu action button in the toolbar to open dialog for adding new NFTs.
  • Improves custom assets dialog.
  • Improves loading spinner behavior.
  • Addresses comment #1150817680.
  • Addresses comment #1151711434.
  • Makes loading placeholder not circular.
  • Improves algorithm to center letters in the blockies.
  • Improves ImageLoader by switching in favor of RequestManager and preventing illegal argument exceptions.
  • Shows token name + ID in the title, and NFT symbol in the subtitle for both screens: NFT grid, and NFT details

Also need to retest #28301 (discussed here https://bravesoftware.slack.com/archives/C023VS4HJ6Q/p1681484659402249)
@simoarpe simoarpe added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Mar 31, 2023
@simoarpe simoarpe self-assigned this Mar 31, 2023
@simoarpe simoarpe mentioned this issue Mar 31, 2023
Closed
@simoarpe simoarpe mentioned this issue Apr 7, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.52.x - Nightly milestone Apr 14, 2023
@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.52.92 x64 beta build

  • Verified steps from brave/brave-core#17967
  • Verified can filter NFTs based on network
  • Verified when adding an NFT, Add button is only enabled when token id is specified
  • Encountered #30273 & #30274
Oppo Reno 5 (Android 13) Lenovo Tab (Android 12)
29444-ARM.mp4
29444-Tab.mp4

@kjozwiak kjozwiak mentioned this issue May 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simoarpe simoarpe

Labels
feature/web3/wallet/nft feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.52.x - Release
Development

Successfully merging a pull request may close this issue.

Integrate multichain support for NFT grid brave/brave-core
3 participants
@simoarpe @srirambv @brave-builds