Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared Pinned Tabs are attempted to be created for PWA windows #29576

Closed
petemill opened this issue Apr 7, 2023 · 0 comments · Fixed by brave/brave-core#17969
Closed

Shared Pinned Tabs are attempted to be created for PWA windows #29576

petemill opened this issue Apr 7, 2023 · 0 comments · Fixed by brave/brave-core#17969

Comments

@petemill
Copy link
Member

petemill commented Apr 7, 2023

Description

This is only guarded with a DCHECK (which causes a crash in debug builds). In release builds it causes pinned tabs to be created on PWA-tabbed windows, and some crashes for non-PWA-tabbed windows.

Steps to Reproduce

  1. Enable shared pinned tabs flag
  2. Create a PWA

Actual result:

In Debug: crash occurs

Expected result:

The PWA window is not considered for pinned tabs

Reproduces how often:

Easily in debug, crash sometimes in release

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment