Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GetEthTokenSymbol and GetEthTokenDecimals core APIs that accept a chain_id and contract_address #29983

Closed
nvonpentz opened this issue Apr 25, 2023 · 0 comments · Fixed by brave/brave-core#18254
Closed

Add GetEthTokenSymbol and GetEthTokenDecimals core APIs that accept a chain_id and contract_address #29983

nvonpentz opened this issue Apr 25, 2023 · 0 comments · Fixed by brave/brave-core#18254
Assignees
@nvonpentz
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA/No release-notes/include
Milestone
1.56.x - Release

Comments

@nvonpentz
Copy link
Member

nvonpentz commented Apr 25, 2023 •
edited
Loading

They should use an eth_call to call the symbol() and decimals() functions of an ERC20 or ERC721 token.
@nvonpentz nvonpentz added this to Web3 Apr 25, 2023
@nvonpentz nvonpentz self-assigned this Apr 25, 2023
@nvonpentz nvonpentz moved this to In Progress in Web3 Apr 25, 2023
@nvonpentz nvonpentz changed the title Add GetTokenInfo core API that accepts a chain_id and contract_address Add GetEthTokenSymbol core API that accepts a chain_id and contract_address Apr 26, 2023
This was referenced Apr 26, 2023
Merged
Closed
@nvonpentz nvonpentz changed the title Add GetEthTokenSymbol core API that accepts a chain_id and contract_address Add GetEthTokenSymbol and GetEthTokenDecimals core APIs that accept a chain_id and contract_address Apr 27, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Web3 Apr 28, 2023
@brave-builds brave-builds added this to the 1.53.x - Nightly milestone Apr 28, 2023
@LaurenWags LaurenWags mentioned this issue Jul 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nvonpentz nvonpentz

Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA/No release-notes/include
Projects
Web3
Archived in project
Milestone
1.56.x - Release
Development

Successfully merging a pull request may close this issue.

Add GetEthTokenSymbol and GetEthTokenDecimals to JsonRpcService brave/brave-core
2 participants
@nvonpentz @brave-builds