Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new tab page settings #2999

Closed
rebron opened this issue Jan 17, 2019 · 51 comments · Fixed by brave/brave-core#6879 or brave/brave-core#6995
Closed

Add new tab page settings #2999

rebron opened this issue Jan 17, 2019 · 51 comments · Fixed by brave/brave-core#6879 or brave/brave-core#6995
Assignees
Labels
browser-laptop-parity design A design change, especially one which needs input from the design team feature/new-tab feature/settings OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-Win64 QA/Yes release-notes/include

Comments

@rebron
Copy link
Collaborator

rebron commented Jan 17, 2019

screen shot 2019-01-16 at 9 56 30 pm

Description

Create new setting 'New tab page shows' with drop down menu:
a) Dashboard with images
b) Homepage
c) Blank page

Related to: #960
and should show in the Get Started section

@petemill
Copy link
Member

We actually need the browser implementation for this as well. As in there is no functionality at the moment for new tabs to open to a specified URL. I’m not sure how much of a priority this would be for our users? Especially since an extension could fulfill that need.

@rebron
Copy link
Collaborator Author

rebron commented Jan 17, 2019

Carryover as a muon feature parity. Separating out from the other issue due to actually having the functionality available.

@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P4 Planned work. We expect to get to it "soon". labels Jan 18, 2019
@rebron rebron added the design A design change, especially one which needs input from the design team label Jan 24, 2019
@rebron
Copy link
Collaborator Author

rebron commented Jan 24, 2019

We should probably reconsider placement. I'd rather these settings be available on the new tab page where it's accessible and relevant than buried in Settings. cc: @karenkliu, @cezaraugusto

@NejcZdovc NejcZdovc added this to the 1.x Backlog milestone Jan 28, 2019
@cezaraugusto
Copy link
Contributor

agree with @rebron. cc @karenkliu for ideas

@srirambv
Copy link
Contributor

++ on @rebron's idea of having it in new tab itself

@tildelowengrimm
Copy link
Contributor

We could have it both places.

@franzjschneider
Copy link

+1 from me on this. Blank new-tab pages are about all I use. Let clutter, less resources, less distraction. Simple.

@rebron rebron removed this from the 1.x Backlog milestone Feb 7, 2019
@ghost
Copy link

ghost commented Mar 13, 2019

tl;dr ... +1 need options set custom URL or page/blank/edit wallpaper background


I installed Brave just now on my Pixel and my Windows 10 Machine. Imported all my bookmarks, made a sync (cool feature), had a look at all my plugins in Chrome, installed them manually on Brave, did all the settings stuff I need on my Android and Windows system for browsing. Uninstalled Bromite on my Android and Chrome on my Windows. I really enjoyed Brave and thought I do not need anything else now. And then I realized that on Brave for Android and for Windows I do not have any options for the new tab page - and I see that (sorry) ugly page with useless information when opening a new tab. Options for the new tab page are essential. This is a letdown, and even at least on Windows I could add a plugin to override, but those plugins cause a lag when opening the custom page on a new tab. I wonder why a project that wants to create something better on the basis of chromium/chrome removes such an important feature. Sigh. Kudos to the devs, no disrespect intended.

@dpedu
Copy link

dpedu commented Mar 21, 2019

+1. It's ridiculous that a browser does not allow us to set a home page.

@rebron
Copy link
Collaborator Author

rebron commented Mar 21, 2019

@dpedu I think you mean for new tab page, we're working on that. For homepage/home button in settings you can set your homepage there when you show the home button. And on startup, you can specify the page you want.

@dpedu
Copy link

dpedu commented Mar 21, 2019

@rebron what I mean by home page is the screen shown when opening a new tab, be it in a new window, tab in an existing window, or when I open the browser. Some of these can be changed w/o an extension, yes, others not.

@bchen32
Copy link

bchen32 commented May 25, 2019

@dpedu Yeah that's just called new tab. Homepage is something else entirely.

@bchen32
Copy link

bchen32 commented May 25, 2019

I wish that the newtab was identical to the chrome one or that it at least changed backgrounds with the theme. Currently, themes can't change the newtab background, which is 50% the reason I even use themes in the first place

@simonhong simonhong self-assigned this Jun 3, 2020
@chakrihacker
Copy link

Any Update on this. I kind of looking for options to have duckduckgo(any other search engine) in the middle of new tab page or an option to make search engine the default tab page

@ghost
Copy link

ghost commented Oct 25, 2020

Having just downloaded Brave I am shocked this feature is not available. It seems quite deliberate as a revenue generator as you have to uncheck a slew of defaults simply to get the page to not show all of the default content on it.

Bad UX...

@bsclifton
Copy link
Member

@wilfra we're working on a fix now - patch is up here for review (thanks @simonhong):
brave/brave-core#6879

This is likely going to be merged to 1.18 which should hit Release channel ~December 8th

@bsclifton
Copy link
Member

Live in Nightly! 😄 Great job, @simonhong
image

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 7, 2020

Verification passed on


Brave | 1.18.69 Chromium: 87.0.4280.88 (Official Build) (64-bit)
-- | --
Revision | 89e2380a3e36c3464b5dd1302349b1382549290d-refs/branch-heads/4280@{#1761}
OS | Windows 10 OS Version 2004 (Build 19041.630)

Verified the test plan from brave/brave-core#6879
Verified both clean and dark mode

Verified that Customize Brave Dashboard settings text is replaced with New tab page shows... and the dropdown has 3 options Dashboard, Homepage and Blank page
image

Light mode:
image
image
image

Dark mode:
image
image
image


Verification passed on

Brave 1.18.70 Chromium: 87.0.4280.101 (Official Build) (64-bit)
Revision 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS Ubuntu 18.04 LTS

Verified the test plan from brave/brave-core#6879
Verified both light and dark mode

Verified that Customize Brave Dashboard settings text is replaced with New tab page shows... and the dropdown has 3 options Dashboard, Homepage and Blank page

image
image

image
image

@rebron rebron changed the title New Tab Page settings Add new tab page settings Dec 7, 2020
@pitsi
Copy link

pitsi commented Dec 11, 2020

Noob question and sorry for bringing this back up.
I am interested in setting a "homepage" (= an html file I have locally) there. So. how do I set that homepage that will open in every new tab?

@simonhong
Copy link
Member

@pitsi That homepage option is related with below homepage option.
If homepage is configured, new tab will show that url. Loading local html file in new tab is not supported.

image

@pitsi
Copy link

pitsi commented Dec 12, 2020

Thank you. Well hidden setting :P

On my end, I can set a local file there (file:///home/user/whatever.html) and it works as a regular page from the net.
Plus, once I set that homepage under show home button, I can disable the home button again and the page still works!
Until today, I was running lighttpd on my system to serve that page locally and I had set it as a page for newtab with new tab redirect. Now I can remove them both :)

@simonhong
Copy link
Member

@pitsi Great tip!

@raiden-e
Copy link

raiden-e commented Sep 24, 2024

Thank you. Well hidden setting :P

On my end, I can set a local file there (file:///home/user/whatever.html) and it works as a regular page from the net. Plus, once I set that homepage under show home button, I can disable the home button again and the page still works! Until today, I was running lighttpd on my system to serve that page locally and I had set it as a page for newtab with new tab redirect. Now I can remove them both :)

I tried this, but setting the homepage to file:///Users/user/source/startpage/index.html won't do it on MacOS. :/

@pitsi
Copy link

pitsi commented Sep 25, 2024

I just tried in on a... quite fresh installation (3 months old) of brave I have on my laptop and it works.
Are you sure you do not have any typos, or that the path is correct or that you have also changed the new tab to show the homepage (it is at the bottom of brave://settings/getStarted).

Also, does it work with online urls like this?
https://instant.unsplash.com/

Debian unstable x64 and brave 1.70.x.

@raiden-e
Copy link

I copied the link from the search bar, so I figure it's correct. I might add, that it DOES work when starting Brave. However, opening a new tab will open the dashboard, instead of the HTML-URL. The setting "New tab page shows" is set to "Homepage". So extra odd.
How about you?

@pitsi
Copy link

pitsi commented Sep 27, 2024

As I said above, do you have set brave to show the homepage on the new tab?

@raiden-e
Copy link

Yes :)

@pitsi
Copy link

pitsi commented Sep 27, 2024

No idea then. Here is how I have set mine. The "show home button toggle" was enabled so as to show the options below it. I have it disabled otherwise.
2024-09-27-195013_1280x1024_scrot
2024-09-27-195135_1280x1024_scrot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-laptop-parity design A design change, especially one which needs input from the design team feature/new-tab feature/settings OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet