Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add empty state shown when NFT auto discovery is enabled #30105

Closed
muliswilliam opened this issue May 3, 2023 · 1 comment · Fixed by brave/brave-core#18344
Closed

Add empty state shown when NFT auto discovery is enabled #30105

muliswilliam opened this issue May 3, 2023 · 1 comment · Fixed by brave/brave-core#18344
Assignees
@muliswilliam
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.56.x - Release

Comments

@muliswilliam
Copy link

muliswilliam commented May 3, 2023 •
edited
Loading

Figma link: https://www.figma.com/file/mvoB5HzIyQT9O4vbcA1XhP/NFT-Tab?type=design&node-id=220%3A97408&t=rfTOXewYHfCvW9TG-1
@muliswilliam muliswilliam added this to Web3 May 3, 2023
@muliswilliam muliswilliam converted this from a draft issue May 3, 2023
@muliswilliam muliswilliam self-assigned this May 3, 2023
@muliswilliam muliswilliam mentioned this issue May 3, 2023
Merged
25 tasks
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 May 12, 2023
@brave-builds brave-builds added this to the 1.53.x - Nightly milestone May 12, 2023
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.53.94 Chromium: 114.0.5735.133 (Official Build) beta (64-bit)
Revision fbfa2ce68d01b2201d8c667c2e73f648a61c4f4a-refs/branch-heads/5735@{#1270}
OS Windows 11 Version 22H2 (Build 22621.1848)
  • Verified steps from brave/brave-core#18344
  • Verified new placeholder empty state is shown when there are no NFTs added
Light Dark
brave_4yLOQkJ9qp brave_L3RqoOSV6H

@LaurenWags LaurenWags mentioned this issue Jul 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muliswilliam muliswilliam

Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.56.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet) Add empty state shown when NFT auto discovery is enabled brave/brave-core
3 participants
@srirambv @brave-builds @muliswilliam