-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve text on aggressive mode interstitial to explain link to aggressive mode #30142
Labels
needs-text-change
This change requires some careful wording.
OS/Android
Fixes related to Android browser functionality
OS/Desktop
privacy/feature
User-facing privacy- & security-focused feature work.
privacy-pod
Feature work for the Privacy & Web Compatibility pod
QA Pass - Android ARM
QA Pass-macOS
QA/Yes
release-notes/include
Milestone
Comments
pes10k
added
OS/Android
Fixes related to Android browser functionality
OS/Desktop
needs-text-change
This change requires some careful wording.
privacy/feature
User-facing privacy- & security-focused feature work.
privacy-pod
Feature work for the Privacy & Web Compatibility pod
labels
May 4, 2023
25 tasks
@pilgrim-brave @pes10k could one of you please provide a test plan for this one as it's labeled |
@LaurenWags this should work:
|
Thanks @pes10k! |
Verified
|
Brave | 1.57.2 Chromium: 115.0.5790.56 (Official Build) beta (x86_64) |
---|---|
Revision | ebcfb87c1393f36955cfa2f6451a1767e3dc3ee5-refs/branch-heads/5790@{#1193} |
OS | macOS Version 11.7.8 (Build 20G1351) |
Steps:
- installed
1.57.2
- launched Brave
- loaded
https://antitracking.owncast.online/
- confirmed no interstitial-blocking message
- switched to
Aggressively block trackers & ads
in the Shields dropdown - confirmed page reloaded, now with intersitial-blocking message
- clicked on
Proceed
- confirmed I was shown
https://antitracking.owncast.online/
without the interstitial
example | example | example | example | example |
---|---|---|---|---|
hffvld
added
the
QA/In-Progress
Indicates that QA is currently in progress for that particular issue
label
Aug 3, 2023
Verified on
STEPS:
ACTUAL RESULTS:
|
hffvld
added
QA Pass - Android ARM
and removed
QA/In-Progress
Indicates that QA is currently in progress for that particular issue
labels
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs-text-change
This change requires some careful wording.
OS/Android
Fixes related to Android browser functionality
OS/Desktop
privacy/feature
User-facing privacy- & security-focused feature work.
privacy-pod
Feature work for the Privacy & Web Compatibility pod
QA Pass - Android ARM
QA Pass-macOS
QA/Yes
release-notes/include
Some users are surprised when they see the interstitial appear in aggressive mode.
https://bravesoftware.slack.com/archives/C6YNM6Y5S/p1683211033792949
It would be good to add additional text stating (straw text)
The text was updated successfully, but these errors were encountered: