Show first-party subtrees without significant text in default cosmetic filtering mode

[antonok-edm]

In standard blocking mode, elements are being unhidden if:

• the tree is first-party, AND
• there is no "significant text"

...when the original design was intended to unhide elements if:

• the tree is first-party, OR
• there is no "significant text"

This is causing unexpected behavior on https://dev-pages.bravesoftware.com/filtering/cosmetic-filtering.html, where the first-party images are being hidden because of the lack of significant text.

[stephendonner]

Verification PASSED using

Brave	1.53.74 Chromium: 114.0.5735.53 (Official Build) beta (x86_64)
Revision	c499d7ea22c8b2dba278465a5df7b86a8efa4e64-refs/branch-heads/5735@{#970}
OS	macOS Version 11.7.7 (Build 20G1345)

Steps:

1. installed 1.53.74
2. launched Brave
3. loaded https://dev-pages.bravesoftware.com/filtering/cosmetic-filtering.html
4. clicked Run tests (with Shields preset to Standard)
5. noted values and content for both first and third partiness
6. set Shields to Aggressive
7. clicked Run tests

Confirmed images for first parties were shown in Standard blocking, and with Aggressive blocking enabled, neither first nor third parties had images

Standard blocking	Aggressive blocking

[hffvld]

Verified on Google Pixel 7 using version(s):

Device/OS: Google Pixel 7 [panther_beta-user 14 UPB2.230407.014 release-keys]
Brave build: 1.53.74
Chromium: 114.0.5735.53 (Official Build) beta (64-bit)
Revision: c499d7ea22c8b2dba278465a5df7b86a8efa4e64-refs/branch-heads/5735@{#970}

---

STEPS:

1. Launch Brave > Open https://dev-pages.bravesoftware.com/filtering/cosmetic-filtering.html
2. Brave Shields > Block trackers & ads > Make sure it set to Standard Mode > Done
3. Tap Run test > Verify results
4. Brave Shields > Block trackers & ads > Set to Aggressive Mode > Done
5. Tap Run test > Verify results

ACTUAL RESULTS:

• Verified that in Standard Mode images are shown only for first Partiness, but not shown for third Partiness
• Verified that in Aggressive Mode images are not shown for both first and third Partiness

Standard	Standard	Aggressive	Aggressive

[MadhaviSeelam]

Verification PASSED using

Brave | 1.53.76 Chromium: 114.0.5735.90 (Official Build) beta (64-bit)
-- | --
Revision | 386bc09e8f4f2e025eddae123f36f6263096ae49-refs/branch-heads/5735@{#1052}
OS | Windows 11 Version 22H2 (Build 22621.1702)

Steps:

1. installed 1.53.76
2. launched Brave
3. loaded https://dev-pages.bravesoftware.com/filtering/cosmetic-filtering.html
4. clicked Run tests (with Shields preset to Standard)
5. noted values and content for both first and third partiness
6. set Shields to Aggressive
7. clicked Run tests

Confirmed images for first parties were shown in Standard blocking, and with Aggressive blocking enabled, neither first nor third parties had images

Confirmed that the images for the first parties were visible in Standard blocking, while third party elements are hidden.

Confirmed that no images are shown in Aggressive blocking mode in both first and third parties

Standard	Aggressive

[MadhaviSeelam]

Verification PASSED using

Brave | 1.53.85 Chromium: 114.0.5735.110 (Official Build) beta (64-bit)
-- | --
Revision | 1c828682b85bbc70230a48f5e345489ec447373e-refs/branch-heads/5735_90@{#13}
OS | Linux

Steps:

1. installed 1.53.85
2. launched Brave
3. loaded https://dev-pages.bravesoftware.com/filtering/cosmetic-filtering.html
4. clicked Run tests (with Shields preset to Standard)
5. noted values and content for both first and third partiness
6. set Shields to Aggressive
7. clicked Run tests

Confirmed images for first parties were shown in Standard blocking, and with Aggressive blocking enabled, neither first nor third parties had images

Confirmed that the images for the first parties were visible in Standard blocking, while third party elements are hidden.

Confirmed that no images are shown in Aggressive blocking mode in both first and third parties

Standard	Aggressive

[kjozwiak]

Verification PASSED on Samsung Galaxy Tab S8 Ultra running Android 13 using the following build(s):

Brave | 1.56.8 Chromium: 115.0.5790.98 (Official Build) (64-bit)
--- | ---
Revision | 4eacc220b55f07c57d5a1f4b7e0e63a6f7e420a1-refs/branch-heads/5790_90@{#4}
OS | Android 13; Build/TP1A.220624.014; 33; REL

STR:

1. Launch Brave > Open https://dev-pages.bravesoftware.com/filtering/cosmetic-filtering.html
2. Brave Shields > Block trackers & ads > Make sure it set to Standard Mode > Done
3. Tap Run test > Verify results
4. Brave Shields > Block trackers & ads > Set to Aggressive Mode > Done
5. Tap Run test > Verify results

ACTUAL RESULTS:

• Verified that in Standard Mode images are shown only for first Partiness, but not shown for third Partiness
• Verified that in Aggressive Mode images are not shown for both first and third Partiness

Standard Mode

Example	**Example**

Aggressive Mode

Example	**Example**