Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extraneous Shields settings label in cookies' site details page #30208

Closed
stephendonner opened this issue May 8, 2023 · 2 comments · Fixed by brave/brave-core#18479
Closed

Comments

@stephendonner
Copy link

stephendonner commented May 8, 2023

Description

Extraneous Shields settings label in cookies' site details page

Steps to Reproduce

  1. install 1.53.26
  2. launch Brave
  3. load youtube.com
  4. sign in and click around a bit
  5. load brave://settings/privacy
  6. click on Cookies and other site data
  7. click on See all site data and permissions
  8. expand the youtube.com down arrow
  9. click on www.youtube.com
  10. you'll end up on brave://settings/content/siteDetails?site=https%3A%2F%2Fwww.youtube.com%2F
  11. look beneath Cookies and Site Data, there's a rogue Shields settings label

Actual Results:

Screen Shot 2023-05-08 at 12 52 37 PM

Expected Results:

No Shields settings label

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.53.26 Chromium: 113.0.5672.77 (Official Build) nightly (x86_64)
Revision c4236862955e005c2187105415ac4a2ecf86dff1-refs/branch-heads/5672_62@{#3}
OS macOS Version 11.7.6 (Build 20G1231)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

/cc @bradleyrichter @pes10k @spylogsster @rebron @aguscruiz @brave/qa-team

@stephendonner
Copy link
Author

Credit to @pes10k who discovered this in https://bravesoftware.slack.com/archives/CKNHM4RTK/p1683298044718789

@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.53.45 Chromium: 114.0.5735.26 (Official Build) nightly (x86_64)
Revision 7075cbb66f0542ac3e01ddfde6b813e7d61118a5-refs/branch-heads/5735@{#454}
OS macOS Version 11.7.6 (Build 20G1231)

Followed my original steps to reproduce.

Confirmed no more extraneous Shields settings label present

Light Dark
Screen Shot 2023-05-16 at 6 53 34 PM Screen Shot 2023-05-16 at 6 53 56 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants