Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not show VPN restore if subscription is not active #30244

Closed
deeppandya opened this issue May 9, 2023 · 1 comment · Fixed by brave/brave-core#18847
Closed

Do not show VPN restore if subscription is not active #30244

deeppandya opened this issue May 9, 2023 · 1 comment · Fixed by brave/brave-core#18847
Assignees
@deeppandya
Labels
feature/vpn OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/include
Milestone
1.57.x - Release

Comments

@deeppandya
Copy link

deeppandya commented May 9, 2023 •
edited
Loading

We need to hide Restore if user doesn't have an active subscription.
This issue should resolve below scenario :

People making high # of support requests on Android

  • They see paywall, they click restore.
  • Then they click contact support
  • Can we remove this if they don't have a real subscription?
  • Fixing cuts out ~60+ emails a day

Test plan

Restore button should not be visible if user doesn't have an active subscription.
@deeppandya deeppandya added QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality feature/vpn labels May 9, 2023
@deeppandya deeppandya self-assigned this May 9, 2023
@deeppandya deeppandya changed the title Hide contact support page when subscription is not available Do not show VPN restore if subscription is not active Jun 9, 2023
@deeppandya deeppandya mentioned this issue Jun 9, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.54.x - Nightly milestone Jun 12, 2023
@brave-builds brave-builds mentioned this issue Jun 12, 2023
Closed
7 tasks
@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Aug 2, 2023
@hffvld
Copy link
Contributor

hffvld commented Aug 3, 2023

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 [panther_beta-user 14 UPB4.230623.007 release-keys]
Brave build: 1.57.33
Chromium: 115.0.5790.114 (Official Build) beta (64-bit) 
Revision: 86b4ea1d70ce73c4468d84cc8277f1f9de14b8bc
Upgraded profile - PASS

STEPS:

  1. Install Brave 1.53.x
  2. Three-dot menu > Brave VPN > Confirm that RESTORE button is shown
  3. Upgrade Brave to 1.57.x
  4. Three-dot menu > Brave VPN > Verify

ACTUAL RESULTS:

  • Verified that RESTORE button is not shown when a user doesn't have an active VPN subscription
1.53.81 1.57.33
1 2
Fresh profile - PASS

STEPS:

  1. Fresh install Brave 1.57.x
  2. Three-dot menu > Brave VPN > Verify

ACTUAL RESULTS:

  • Verified that RESTORE button is not shown when a user doesn't have an active VPN subscription
1.57.33
1

@hffvld hffvld added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Aug 3, 2023
@kjozwiak kjozwiak mentioned this issue Aug 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

Labels
feature/vpn OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/include
Projects
None yet
Milestone
1.57.x - Release
Development

Successfully merging a pull request may close this issue.

Do not show vpn restore for no active subscription brave/brave-core
3 participants
@deeppandya @brave-builds @hffvld