Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct network instead of default for transactions list and Tx approval #30277

Closed
Pavneet-Sing opened this issue May 11, 2023 · 1 comment · Fixed by brave/brave-core#18477
Closed

Use correct network instead of default for transactions list and Tx approval #30277

Pavneet-Sing opened this issue May 11, 2023 · 1 comment · Fixed by brave/brave-core#18477
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/include
Milestone
1.56.x - Release

Comments

@Pavneet-Sing
Copy link

Pavneet-Sing commented May 11, 2023 •
edited
Loading

Description

Currently Android is showing all transactions with invalid amount/gas (due to using default network). getAllTransactionInfo needs a chain_id to get network specific transactions.

Steps to reproduce

  1. Open account details
  2. Create transactions on multiple networks having same coin type
  3. View list of transactions showing all transaction with invalid balance/gas for the same account

Actual result

Showing all transaction instead of network specific tx with invalid amount/gas by using the current selected network.
All transactions are not BNB tx, but are Sol or Eth.

Screenshot from 2023-05-11 16-49-59

Expected result

Correct network and gas on transactions list or tx approval
@Pavneet-Sing Pavneet-Sing added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels May 11, 2023
@Pavneet-Sing Pavneet-Sing changed the title Show only network specific transactions Use correct network instead of default for transactions list and Tx approval May 11, 2023
@Pavneet-Sing Pavneet-Sing mentioned this issue May 15, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.53.x - Nightly milestone May 16, 2023
@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 13 running 1.53.94 x64 Beta build

  • Verified steps from brave/brave-core#18477
  • Verified correct network name and token details are shown for unapproved transactions under account details
  • Verified Solana account only shows unapproved Solana transactions
  • Verified Ethereum Account only shows unapproved Ethereum and EVM transactions
30277.mp4

@srirambv srirambv mentioned this issue Jun 15, 2023
Closed
@kjozwiak kjozwiak mentioned this issue Jul 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.56.x - Release
Development

Successfully merging a pull request may close this issue.

Fix transaction balance and network brave/brave-core
3 participants
@Pavneet-Sing @srirambv @brave-builds