Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new design for NFT details screen #30286

Closed
muliswilliam opened this issue May 11, 2023 · 1 comment · Fixed by brave/brave-core#18457
Closed

Implement new design for NFT details screen #30286

muliswilliam opened this issue May 11, 2023 · 1 comment · Fixed by brave/brave-core#18457
Assignees
@muliswilliam
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.56.x - Release

Comments

@muliswilliam
Copy link

No description provided.

@muliswilliam muliswilliam self-assigned this May 11, 2023
@muliswilliam muliswilliam converted this from a draft issue May 11, 2023
@muliswilliam muliswilliam changed the title Add NFT details screen using Wallet v2 designs Implement new design for NFT details screen May 11, 2023
@muliswilliam muliswilliam mentioned this issue May 11, 2023
Merged
25 tasks
@github-project-automation github-project-automation bot moved this from In Progress to Done in Web3 May 16, 2023
@brave-builds brave-builds added this to the 1.53.x - Nightly milestone May 16, 2023
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.53.94 Chromium: 114.0.5735.133 (Official Build) beta (64-bit)
Revision fbfa2ce68d01b2201d8c667c2e73f648a61c4f4a-refs/branch-heads/5735@{#1270}
OS Windows 11 Version 22H2 (Build 22621.1848)
  • Verified steps from brave/brave-core#18457
  • Verified NFT details screen shows the new layout
  • Verified when NFT details is loaded shows IPFS pinning status
  • Verified if NFT details are not loaded continues to show the error message
30286.mp4

@LaurenWags LaurenWags mentioned this issue Jul 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muliswilliam muliswilliam

Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.56.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet) Implement new design for NFT details screen(wallet v2) brave/brave-core
3 participants
@srirambv @brave-builds @muliswilliam